Skip to content

Add 'Query.num_dml_affected_rows' property. - #3460

Merged
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:2920-bigquery-num_dml_affected_rows
May 31, 2017
Merged

Add 'Query.num_dml_affected_rows' property.#3460
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:2920-bigquery-num_dml_affected_rows

Conversation

@tseaver

@tseavertseaver commented May 31, 2017

Copy link
Copy Markdown
Contributor

Read-only, set from servier-provided numDmlAffectedRows field.

Closes#2920.

@tseavertseaver added api: bigquery Issues related to the BigQuery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels May 31, 2017
@tseaver
tseaver requested review from dhermes and tswastMay 31, 2017 17:15
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label May 31, 2017
dhermes
dhermes approved these changes May 31, 2017
View reviewed changes

@dhermesdhermes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but @tseaver can you hold-off merging until @tswast has a look?

@dhermes

dhermes commented May 31, 2017

Copy link
Copy Markdown
Contributor

@tseaver CI is red for a missed coverage line

tswast
tswast approved these changes May 31, 2017
View reviewed changes

@tswasttswast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tseaver
Add 'Query.num_dml_affected_rows' property.
c9e6a40
Read-only, set from servier-provided 'numDmlAffectedRows' field.
Closes#2920.
@tseaver

tseaver commented May 31, 2017

Copy link
Copy Markdown
ContributorAuthor

@dhermes Odd, a bare nox passed fine on this branch on my local machine. I've pushed a change which should fix it.

@tseaver
tseaver merged commit 7e73e78 into googleapis:masterMay 31, 2017
@tseaver
tseaver deleted the 2920-bigquery-num_dml_affected_rows branch May 31, 2017 17:54
@tseavertseaver mentioned this pull request May 31, 2017
Closed
@tseavertseaver mentioned this pull request Jun 26, 2017
Merged
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@tseaver@landrito
Add 'Query.num_dml_affected_rows' property. (googleapis#3460)
9e44ba0
Read-only, set from servier-provided 'numDmlAffectedRows' field.
Closesgoogleapis#2920.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@tseaver@landrito
Add 'Query.num_dml_affected_rows' property. (googleapis#3460)
3d6adcd
Read-only, set from servier-provided 'numDmlAffectedRows' field.
Closesgoogleapis#2920.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@tseaver@landrito
Add 'Query.num_dml_affected_rows' property. (googleapis#3460)
84bb5d0
Read-only, set from servier-provided 'numDmlAffectedRows' field.
Closesgoogleapis#2920.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswasttswasttswast approved these changes
+1 more reviewer
@dhermesdhermesdhermes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the BigQuery API.cla: yesThis human has signed the Contributor License Agreement.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver@dhermes@tswast@googlebot