Uh oh!
There was an error while loading. Please reload this page.
Support 'user_project' in '_PropertyMixin.{reload,patch}'. - #3489
Closed
tseaver wants to merge 5 commits into
Closed
Support 'user_project' in '_PropertyMixin.{reload,patch}'.#3489tseaver wants to merge 5 commits into
tseaver wants to merge 5 commits into
Conversation
Toward #3474. Note that the new system test is skipped, because 'Buckets.insert' fails with the 'billing/requesterPays' field set, both in our system tests and in the 'Try It!' form in the docs.
Use it in the (still skipped) system test.
If we can figure out how to determing that the feature is availalbe programatically later, we can adjust the 'REQUESTER_PAYS_ENABLED' flag, which will also be available to guard other system tests using it. [ci skip]
This was referenced Jun 8, 2017
tseaver
commented
Jun 9, 2017
ContributorAuthor
Oops, turns out this one needs to be folded in with #3490. |
tseaver
deleted the
3474-storage-bucket-requester_pays-_propertymixin-apis
branch
June 9, 2017 19:19
dhermes
commented
Jun 9, 2017
Contributor
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses #3488 as a base.