Add back pylint as info-only for core by theacodes · Pull Request #3515 · googleapis/google-cloud-python

theacodes · 2017-06-20T20:21:23Z

No description provided.

Sign in to view

+ '--library-filesets', 'google',
+ '--test-filesets', 'tests',
+ # Temporarily allow this to fail.
+ success_codes=range(0, 100))


Sign in to view

 session.install('.')
 session.run('flake8', 'google/cloud/core')
+ session.run(
+ 'gcp-devrel-py-tools', 'run-pylint',


theacodes · 2017-06-22T17:36:16Z

@dhermes added a "empty" config file for you. PTAL?

Sign in to view

+# Test configuration
+
+# test_additions = copy.deepcopy(library_additions)
+# test_replacements = copy.deepcopy(library_replacements)


dhermes · 2017-06-22T19:15:21Z

This LGTM.

theacodes · 2017-06-22T19:46:26Z

Cool, I'll send another PR to add this to all the other packages.

dhermes · 2017-06-22T19:54:33Z

SGTM. Do we think @lukesneeringer cares? (Prepare for some lint violations since we've had it turned off.)

theacodes · 2017-06-22T20:00:53Z

It's in info-only mode so it will not cause any new failures. Luke gave approval in the email chain you were on.

dhermes · 2017-06-22T20:02:32Z

Boom roasted

Add back pylint as info-only for core
c432753

theacodes requested review from dhermes and lukesneeringer June 20, 2017 20:21

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 20, 2017

dhermes reviewed Jun 20, 2017
View reviewed changes

Add empty pylint config
5fdfd67

dhermes reviewed Jun 22, 2017
View reviewed changes

theacodes merged commit 46ced00 into googleapis:masterJun 22, 2017

theacodes deleted the pylint-for-core branch June 22, 2017 19:46

tseaver mentioned this pull request Jun 26, 2017
Prep core-0.25.0 release. #3526
Merged

landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
Add back pylint as info-only for core (googleapis#3515)
4993148

landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
Add back pylint as info-only for core (googleapis#3515)
26398aa

landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
Add back pylint as info-only for core (googleapis#3515)
c1f9f4f

parthea pushed a commit that referenced this pull request Nov 24, 2025
Add back pylint as info-only for core (#3515)
64e37c4

Uh oh!

Conversation

theacodes commented Jun 20, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

theacodes commented Jun 22, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Jun 22, 2017

Uh oh!

theacodes commented Jun 22, 2017

Uh oh!

dhermes commented Jun 22, 2017

Uh oh!

theacodes commented Jun 22, 2017 via email • edited by dhermes Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dhermes commented Jun 22, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

theacodes commented Jun 22, 2017 via email •
edited by dhermes
Loading