Skip to content

Re-enable pylint in info-only mode for all packages - #3519

Merged
theacodes merged 2 commits into
googleapis:masterfrom
theacodes:lint-all-the-things
Jun 23, 2017
Merged

Re-enable pylint in info-only mode for all packages#3519
theacodes merged 2 commits into
googleapis:masterfrom
theacodes:lint-all-the-things

Conversation

@theacodes

Copy link
Copy Markdown
Contributor

No description provided.

@theacodes
theacodes requested a review from dhermesJune 22, 2017 20:47
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 22, 2017
@dhermes

Copy link
Copy Markdown
Contributor

A cursory scan looks fine, though ISTM we should have a single pylint.config.py at the project root and then every package points at that?

@theacodes

Copy link
Copy Markdown
ContributorAuthor

I'd do that but @lukesneeringer is planning on splitting packages into their own repos.

@dhermes

Copy link
Copy Markdown
Contributor

Yeah in that context it totally makes sense.

@tseaver

Copy link
Copy Markdown
Contributor

@jonparrott I'm missing what makes running pylint this way "advisory only": can you elaborate?

@theacodes

Copy link
Copy Markdown
ContributorAuthor

@tseaver nox is ignoring its return value, so pylint can fail but the lint session will still pass.

@theacodes

Copy link
Copy Markdown
ContributorAuthor

@dhermes@lukesneeringer y'all got any more of them LGTMs?

@dhermes

Copy link
Copy Markdown
Contributor

LGTM

landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@theacodes@dhermes@tseaver@googlebot