NL GAPIC Shim by lukesneeringer · Pull Request #3590 · googleapis/google-cloud-python

lukesneeringer · 2017-07-06T21:01:45Z

This implements the manual code and documentation to augment moving Natural Language to GAPIC only.

Using nl-gapic as a base branch so reviewers do not have to look at the auto-gen.

dhermes · 2017-07-06T21:14:37Z

@lukesneeringer What in particular would you like reviewed?

lukesneeringer · 2017-07-10T19:52:37Z

@dhermes Sanity check mostly.

Sign in to view

- gapic/api
- gapic/types
+ gapic/v1/api
+ gapic/v1/types


Sign in to view

+for name, message in get_messages(language_service_pb2).items():
+ message.__module__ = 'google.cloud.language_v1.types'
+ setattr(sys.modules[__name__], name, message)
+ names.append(name)


Sign in to view

 SETUP_BASE = {
 'author': 'Google Cloud Platform',
- 'author_email': 'jjg+google-cloud-python@google.com',
+ 'author_email': 'googleapis-publisher@google.com',


Sign in to view

@@ -0,0 +1,30 @@
+# Copyright 2017, Google Inc. All rights reserved.


Sign in to view

+# limitations under the License.
+"""Unit tests."""
+
+import mock


Sign in to view

+from google.cloud.proto.language.v1 import language_service_pb2
+
+
+class CustomException(Exception):


Sign in to view

 REQUIREMENTS = [
 'google-cloud-core >= 0.25.0, < 0.26dev',
- 'google-gax >= 0.15.7, < 0.16dev',
+ 'google-gax >= 0.15.13, < 0.16dev',


Sign in to view

+ document=document, encoding_type=encoding_type)
+ self.assertEqual(expected_request, actual_request)
+
+ @mock.patch('google.gax.config.API_ERRORS', (CustomException, ))


lukesneeringer · 2017-07-26T17:39:27Z

Merging this despite the PubSub Circle failure (which is unrelated).

Luke Sneeringer added 3 commits July 5, 2017 10:09

Add manual shims around the v1 and v1beta2 GAPICs.
29a9cb3

Add unit tests. The system tests will not run in the current config.
136909a

Update NL docs.
7040011

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 6, 2017

lukesneeringer requested a review from dhermes July 6, 2017 21:02

Luke Sneeringer added 2 commits July 7, 2017 10:39

Add gax to setup.py
b162f47

Update setup.py
ffb453d

dhermes reviewed Jul 10, 2017
View reviewed changes

Fix type mismatch.
44362ad

lukesneeringer commented Jul 11, 2017
View reviewed changes

Comment threadlanguage/tests/gapic/v1/test_language_service_client_v1.py
document=document, encoding_type=encoding_type)
self.assertEqual(expected_request, actual_request)

@mock.patch('google.gax.config.API_ERRORS', (CustomException, ))
This comment was marked as spam.
Sign in to view

dhermes mentioned this pull request Jul 11, 2017
Updating author_email in all setup.py. #3598
Merged

lukesneeringer merged commit 193b1f4 into nl-gapicJul 26, 2017

lukesneeringer deleted the nl-gapic-shim branch July 26, 2017 17:39

lukesneeringer mentioned this pull request Jul 26, 2017
NL GAPIC #3679
Merged

		@@ -0,0 +1,30 @@
		# Copyright 2017, Google Inc. All rights reserved.

		from google.cloud.proto.language.v1 import language_service_pb2


		class CustomException(Exception):

Uh oh!

Conversation

lukesneeringer commented Jul 6, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dhermes commented Jul 6, 2017

Uh oh!

lukesneeringer commented Jul 10, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

lukesneeringer commented Jul 26, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lukesneeringer commented Jul 6, 2017•
edited
Loading