Speech GAPIC to master by lukesneeringer · Pull Request #3607 · googleapis/google-cloud-python

lukesneeringer · 2017-07-14T18:08:31Z

This is #3483, but using master as the base.
The previous PR only included manual code to ease review.

lukesneeringer · 2017-07-14T18:11:04Z

@dhermes Would you please look over setup.py and speech/setup.py? (Merge conflicts.)

Sign in to view


 Assuming your environment is set up as described in that document,
-create an instance of :class:`~google.cloud.speech.client.Client`.
+create an instance of :class:`~.google.cloud.speech.SpeechClient`.


Sign in to view

- ... speech_contexts=hints,
+ >>> from google.cloud import speech
+ >>> client = speech.SpeechClient()
+ >>> result = client.recognize(


Sign in to view

- ... max_alternatives=1,
- ... profanity_filter=True,
+ >>> client = speech.SpeechClient()
+ >>> result = client.recognize(


Sign in to view

 # Install Sphinx and also all of the google-cloud-* packages.
 session.chdir(os.path.realpath(os.path.dirname(__file__)))
 session.install('Sphinx >= 1.6.2', 'sphinx_rtd_theme')
+ session.install('-e', '.')


Sign in to view

@@ -0,0 +1,86 @@
+# Copyright 2016 Google Inc. All rights reserved.


Sign in to view

+ @mock.patch.object(_helpers, 'make_secure_stub',
 return_value=mock.sentinel.stub)
- def test_constructor(self, mocked_stub, mocked_cls, mocked_channel):
+ def test_constructor(self, mocked_stub, mocked_init, mocked_channel):


Sign in to view

 mocked_channel.assert_called_once_with(
 mock_cnxn.credentials, DEFAULT_USER_AGENT,
-mocked_cls.SERVICE_ADDRESS)
+'speech.googleapis.com')


Sign in to view

+from google.auth.credentials import Credentials
+
+from google.cloud.speech_v1 import SpeechClient
+from google.cloud.speech_v1 import types


Sign in to view

+from google.cloud.speech_v1 import types
+
+
+class HelperTests(unittest.TestCase):


Sign in to view

+
+
+class HelperTests(unittest.TestCase):
+ def setUp(self):


…google-cloud-python into speech-gapic-vendor

googlebot · 2017-07-14T21:03:33Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

dhermes · 2017-07-14T21:44:22Z

$ git log speech-0.26.0..speech-0.27.0 --pretty=%H -- speech/
401bf4018ae8eaf4fabc77e4aac30564e9289aab
da3a7bbe8c7770540c2149fabfc6f74db89f7ce4
bc7b0fdb9fd99b2c86de9830a25cfaaa295b1c45
2a4511ca8a9a4b0569c583a7c4ca6ba0aaf06545
b9cb6d17236528ddce982c3e802af3221de80880
39feb3e23d451963ca31b383d8b395afcf7ab817
6ab3e0127a1edf8b1f9f1603f3c1342473563ea7

These correspond to

Speech GAPIC to master #3607 (this PR)
Updating author_email in all setup.py. #3598 (author_email fix in setup.py)
Shorten nox virtualenv names to avoid hashing. #3585 (nox custom session names)
Change speechContext to speechContexts. #3570 (actual bugfix 'speechContext' -> 'speechContexts')
Skipping system tests when credentials env. var is unset. #3475 (nox option to session.skip nonsense)
Making all LICENSE headers "uniform". #3563 (LICENSE header nonsense)
Fix inclusion of tests in manifest.in #3552 (MANIFEST.in fix)

@dhermes

* Vendor the GAPIC for Speech. * Speech Partial Veneer (googleapis#3483) * Update to docs based on @dhermes catch. * Fix incorrect variable. * Fix the docs. * Style fixes to unit tests. * More PR review from me.

@dhermes

* Vendor the GAPIC for Speech. * Speech Partial Veneer (googleapis#3483) * Update to docs based on @dhermes catch. * Fix incorrect variable. * Fix the docs. * Style fixes to unit tests. * More PR review from me.

@dhermes

* Vendor the GAPIC for Speech. * Speech Partial Veneer (googleapis#3483) * Update to docs based on @dhermes catch. * Fix incorrect variable. * Fix the docs. * Style fixes to unit tests. * More PR review from me.

@dhermes

* Vendor the GAPIC for Speech. * Speech Partial Veneer (#3483) * Update to docs based on @dhermes catch. * Fix incorrect variable. * Fix the docs. * Style fixes to unit tests. * More PR review from me.

@dhermes

* Vendor the GAPIC for Speech. * Speech Partial Veneer (#3483) * Update to docs based on @dhermes catch. * Fix incorrect variable. * Fix the docs. * Style fixes to unit tests. * More PR review from me.

@dhermes

* Vendor the GAPIC for Speech. * Speech Partial Veneer (#3483) * Update to docs based on @dhermes catch. * Fix incorrect variable. * Fix the docs. * Style fixes to unit tests. * More PR review from me.

Luke Sneeringerand others added 2 commits June 7, 2017 08:03

Vendor the GAPIC for Speech.
95c81f9

Speech Partial Veneer (#3483)
3799b75

lukesneeringer self-assigned this Jul 14, 2017

lukesneeringer requested a review from dhermes July 14, 2017 18:08

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 14, 2017

Merge branch 'master' into speech-gapic-vendor
a1bc73a

lukesneeringer added 2 commits July 14, 2017 11:18

Update to docs based on@dhermescatch.
d3cf8c9

Fix incorrect variable.
4492b9e

dhermes reviewed Jul 14, 2017
View reviewed changes

lukesneeringerand others added 3 commits July 14, 2017 13:29

Fix the docs.
fe8bab0

Merge branch 'speech-gapic-vendor' of github.com:GoogleCloudPlatform/…
9002b92
…google-cloud-python into speech-gapic-vendor

Style fixes to unit tests.
f06e31b

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 14, 2017

More PR review from me.
8ff91bd

dhermes merged commit 401bf40 into masterJul 14, 2017

dhermes deleted the speech-gapic-vendor branch July 14, 2017 21:22

dhermes mentioned this pull request Jul 27, 2017
Speech system test are broken #3690
Closed

		@@ -0,0 +1,86 @@
		# Copyright 2016 Google Inc. All rights reserved.

		from google.cloud.speech_v1 import types


		class HelperTests(unittest.TestCase):

Uh oh!

Conversation

lukesneeringer commented Jul 14, 2017

Uh oh!

lukesneeringer commented Jul 14, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

googlebot commented Jul 14, 2017

Uh oh!

dhermes commented Jul 14, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants