Add base future package to google.cloud by theacodes · Pull Request #3616 · googleapis/google-cloud-python

theacodes · 2017-07-17T19:21:02Z

No description provided.

theacodes · 2017-07-17T19:35:23Z

Towards #3617

Sign in to view

 raise ValueError('%r could not be converted to unicode' % (value,))


+def _from_any_pb(pb_type, any_pb):


Sign in to view

+ any_pb (google.protobuf.any_pb2.Any): the object to be converted.
+
+ Returns:
+ pb_type: An instance of the pb_type message.


Sign in to view

@@ -0,0 +1,21 @@
+# Copyright 2017, Google Inc.


Sign in to view

+ """
+
+ @abc.abstractmethod
+ def cancel(self): # pragma: NO COVER


Sign in to view

+
+@six.add_metaclass(abc.ABCMeta)
+class Future(object):
+ # pylint: disable=missing-docstring, invalid-name


Sign in to view

@@ -0,0 +1,52 @@
+# Copyright 2017, Google Inc.


dhermes · 2017-07-17T20:50:43Z

LGTM

Sign in to view

+
+ """Future interface.
+
+ This interface is based on :class:`concurrent.futures.Future`.


Jon Wayne Parrott added 2 commits July 17, 2017 11:12

Add _from_any_pb helper
1c2985e

Add future bases
9a30dc9

theacodes added api: core DevEx labels Jul 17, 2017

theacodes requested review from dhermes and lukesneeringer July 17, 2017 19:21

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 17, 2017

theacodes mentioned this pull request Jul 17, 2017
Add new Future package google.gax.future googleapis/gax-python#195
Closed

dhermes reviewed Jul 17, 2017
View reviewed changes

Jon Wayne Parrott added 2 commits July 17, 2017 12:47

Fix coverage
7b6bab4

Address review comments
bc47d72

Skip notimplementederror in covaragerc
89e38b9

theacodes merged commit 9c06b35 into googleapis:masterJul 17, 2017

theacodes deleted the future branch July 17, 2017 21:27

duggelz reviewed Jul 17, 2017
View reviewed changes

dhermes mentioned this pull request Aug 4, 2017
Cutting release google-cloud-core==0.26.0. #3727
Merged

landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
Add base future package to google.cloud (googleapis#3616)
4237a80

landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
Add base future package to google.cloud (googleapis#3616)
cf2b636

landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
Add base future package to google.cloud (googleapis#3616)
a26aa32

parthea pushed a commit that referenced this pull request Nov 24, 2025
Add base future package to google.cloud (#3616)
c211446

		raise ValueError('%r could not be converted to unicode' % (value,))


		def _from_any_pb(pb_type, any_pb):


		"""Future interface.

		This interface is based on :class:`concurrent.futures.Future`.

Uh oh!

Conversation

theacodes commented Jul 17, 2017

Uh oh!

theacodes commented Jul 17, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Jul 17, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants