Add operation future by theacodes · Pull Request #3618 · googleapis/google-cloud-python

theacodes · 2017-07-17T23:18:53Z

Note: This adds a dependency on the tenacity library. It's worth it.

Towards #3617

Sign in to view

+
+ Args:
+ operation (dict): Operation as a dictionary.
+ api_request (Callable): A callable used to make an API request. This


lukesneeringer

This seems fine to me. No issues adding tenacity.

dhermes

High-level: Do LRO RPC services give trailers describing when to retry?

Sign in to view

 'google-auth >= 0.4.0, < 2.0.0dev',
 'google-auth-httplib2',
 'six',
+ 'tenacity >= 4.0.0, <5.0.0dev'


Sign in to view

 """Abstract and helper bases for Future implementations."""

 import abc
+import concurrent.futures


Sign in to view


- The private :meth:`_blocking_poll` method should be implemented by
- subclasses.
+ The private :meth:`done` method should be implemented by


Sign in to view

 """
- # pylint: disable=missing-raises
- raise NotImplementedError()
+ if self._result_set:


Sign in to view

+ if self._result_set:
+ return
+
+ retry_on = tenacity.retry_if_result(lambda result: result is not True)


Sign in to view

+ self.set_exception(exception)
+ else:
+ exception = exceptions.GoogleCloudError(
+ 'Unknown operation error')


Sign in to view

+ bool: True if the operation is complete, False otherwise.
+ """
+ operation = self._refresh_and_update()
+ return operation.done


Sign in to view

+
+ Args:
+ operation (dict): Operation as a dictionary.
+ api_request (Callable): A callable used to make an API request. This


Sign in to view

+ Args:
+ operation (dict): Operation as a dictionary.
+ api_request (Callable): A callable used to make an API request. This
+ should generally be an instance of


Sign in to view

+ to a given API) vis `HTTP/JSON`_.
+
+ .. _HTTP/JSON: https://cloud.google.com/speech/reference/rest/\
+ v1beta1/operations#Operation


Sign in to view

 exception = exceptions.GoogleCloudError(
- 'Unknown operation error')
+ 'Unexpected state: Long-running operation had neither '
+ 'response nor error set.')


theacodes · 2017-07-18T20:58:02Z

@dhermes the latest release of resumable-media seems to have broken circle. Do you want me to hold off on merging this until you can resolve that? (Master will be broken by it either way).

theacodes · 2017-07-19T16:06:02Z

Rebased and waiting on CI to merge.

theacodes added api: core DevEx labels Jul 17, 2017

theacodes requested review from dhermes and lukesneeringer July 17, 2017 23:18

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 17, 2017

theacodes commented Jul 17, 2017
View reviewed changes

Comment threadcore/google/cloud/future/operation.py

Args:
operation (dict): Operation as a dictionary.
api_request (Callable): A callable used to make an API request. This
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view

lukesneeringer approved these changes Jul 17, 2017
View reviewed changes

This was referenced Jul 18, 2017
Update bigtable to use operation.future #3623
Merged
Remove references to google.cloud.operation from spanner #3625
Merged

dhermes reviewed Jul 18, 2017
View reviewed changes

Comment threadcore/google/cloud/future/operation.py
exception = exceptions.GoogleCloudError(
'Unknown operation error')
'Unexpected state: Long-running operation had neither '
'response nor error set.')
This comment was marked as spam.
Sign in to view

theacodes mentioned this pull request Jul 18, 2017
Add Future interface to BigQuery jobs #3626
Merged

Jon Wayne Parrott added 4 commits July 19, 2017 09:05

Add operation future
16e3c9f

Make background thread test more deterministic
c8e5f98

Address review comments
5163cc1

Fix docstring
57e7f46

theacodes force-pushed the future branch from dde3d9b to 57e7f46Compare July 19, 2017 16:05

theacodes merged commit c565801 into googleapis:masterJul 19, 2017

theacodes deleted the future branch July 19, 2017 16:41

theacodes mentioned this pull request Jul 21, 2017
Remove _OperationFuture googleapis/gax-python#197
Open

dhermes mentioned this pull request Aug 4, 2017
Cutting release google-cloud-core==0.26.0. #3727
Merged

landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
Add operation future (googleapis#3618)
afa2495

landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
Add operation future (googleapis#3618)
855b728

landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
Add operation future (googleapis#3618)
5706cd2

parthea pushed a commit that referenced this pull request Nov 24, 2025
Add operation future (#3618)
a0b84ef

Uh oh!

Conversation

theacodes commented Jul 17, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

lukesneeringer left a comment

Choose a reason for hiding this comment

Uh oh!

dhermes left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

theacodes commented Jul 18, 2017

Uh oh!

theacodes commented Jul 19, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants