Skip to content

Fix #354: support slash in key names - #364

Merged
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:354-support_slash_in_key_names
Nov 11, 2014
Merged

Fix #354: support slash in key names#364
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:354-support_slash_in_key_names

Conversation

@tseaver

Copy link
Copy Markdown
Contributor

Quote 'key.name' properly when used in URL path / query string.

Fixes#354.

@tseavertseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: storage Issues related to the Cloud Storage API. labels Nov 10, 2014
@tseavertseaver mentioned this pull request Nov 10, 2014
Comment threadgcloud/storage/key.py Outdated

This comment was marked as spam.

@coveralls

Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling d4409f4 on tseaver:354-support_slash_in_key_names into * on GoogleCloudPlatform:master*.

Comment threadpylintrc_default Outdated

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@coveralls

Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 7de8081 on tseaver:354-support_slash_in_key_names into * on GoogleCloudPlatform:master*.

@tseavertseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 10, 2014
@tseavertseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 11, 2014
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling a7898da on tseaver:354-support_slash_in_key_names into 95e80e1 on GoogleCloudPlatform:master.

@tseaver

Copy link
Copy Markdown
ContributorAuthor

@dhermes rebased.

@dhermes

Copy link
Copy Markdown
Contributor

LGTM

tseaver added a commit that referenced this pull request Nov 11, 2014
@tseaver
tseaver merged commit bc8b1c4 into googleapis:masterNov 11, 2014
@tseaver
tseaver deleted the 354-support_slash_in_key_names branch February 6, 2015 18:43
urshala pushed a commit to urshala/google-cloud-python that referenced this pull request Jan 17, 2020
atulep pushed a commit that referenced this pull request Apr 6, 2023
Source-Link: googleapis/synthtool@f15cc72
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bc5eed3804aec2f05fad42aacf973821d9500c174015341f721a984a0825b6fd
atulep pushed a commit that referenced this pull request Apr 18, 2023
Source-Link: googleapis/synthtool@f15cc72
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bc5eed3804aec2f05fad42aacf973821d9500c174015341f721a984a0825b6fd
parthea added a commit that referenced this pull request Jun 4, 2023
* fix(deps): allow protobuf 3.19.5
* explicitly exclude protobuf 4.21.0
parthea pushed a commit that referenced this pull request Sep 20, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
…ialogflow products (#364)
PiperOrigin-RevId: 389905442
Source-Link: googleapis/googleapis@4c984f3
Source-Link: googleapis/googleapis-gen@ea3337a
feat: add language code to streaming recognition result
feat: add time zone and security settings to conversation profile
docs: fix validation result docs
docs: update environment docs
docs: update agent docs docs: update entity type docs docs: update intent docs
parthea added a commit that referenced this pull request Sep 22, 2023
* chore(python): drop python 3.6
Source-Link: googleapis/synthtool@4f89b13
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c
* require python 3.7+ in setup.py
* remove python 3.6 sample configs
* update api_description in repo-metadata
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
Source-Link: https://togithub.com/googleapis/synthtool/commit/5f2a6089f73abf06238fe4310f6a14d6f6d1eed3
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97
parthea pushed a commit that referenced this pull request Sep 22, 2023
Source-Link: googleapis/synthtool@56da63e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:993a058718e84a82fda04c3177e58f0a43281a996c7c395e0a56ccc4d6d210d7
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
- [x] Regenerate this pull request now.
fix: resolve DuplicateCredentialArgs error when using credentials_file
committer: parthea
PiperOrigin-RevId: 425964861
Source-Link: googleapis/googleapis@84b1a5a
Source-Link: googleapis/googleapis-gen@4fb761b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGZiNzYxYmJkODUwNmFjMTU2ZjQ5YmFjNWYxODMwNmFhOGViM2FhOCJ9
parthea pushed a commit that referenced this pull request Oct 21, 2023
Source-Link: googleapis/synthtool@25083af
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Oct 21, 2023
* fix(deps): Require google-api-core >=1.34.0, >=2.11.0
fix: Drop usage of pkg_resources
fix: Fix timeout default values
docs(samples): Snippetgen should call await on the operation coroutine before calling result
PiperOrigin-RevId: 493260409
Source-Link: googleapis/googleapis@fea4387
Source-Link: googleapis/googleapis-gen@387b734
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzg3YjczNDRjNzUyOWVlNDRiZTg0ZTYxM2IxOWE4MjA1MDhjNjEyYiJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* add gapic_version.py
* add gapic_version.py
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
Source-Link: googleapis/synthtool@7ff4aad
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:462782b0b492346b2d9099aaff52206dd30bc8e031ea97082e6facecc2373244
parthea pushed a commit that referenced this pull request Oct 21, 2023
)
Source-Link: googleapis/synthtool@7804ade
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:eede5672562a32821444a8e803fb984a6f61f2237ea3de229d2de24453f4ae7d
parthea pushed a commit that referenced this pull request Oct 22, 2023
Source-Link: googleapis/synthtool@f15cc72
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bc5eed3804aec2f05fad42aacf973821d9500c174015341f721a984a0825b6fd
parthea pushed a commit that referenced this pull request Nov 24, 2025
Source-Link: googleapis/synthtool@0142f35
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:99ab465187b4891e878ee4f9977b4a6aeeb0ceadf404870c416c50e06500eb42
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
Source-Link: googleapis/synthtool@06e8279
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:b3500c053313dc34e07b1632ba9e4e589f4f77036a7cf39e1fe8906811ae0fce
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
* updated CHANGELOG.md [ci skip]
* updated setup.py [ci skip]
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Mar 2, 2026
* Exclude unreachable test lines from coverage
* Skip abstract methods and unused code in coverage
* Assure batch ERROR status is actually set in test
One of the tests attempted to set an ERROR status on a batch, but
that batch was a mock, meaning that setting a status had no effect.
If there was a bug in the corresponding code path, the test would
probably not catch it, as that code patch would not be taken.
* Skip code branch that is currently not taken
* Silence deprecation warning in two gapic tests
The tests for flattened arguments to the sync pull() method
hit a code path that emits a deprecation warning, but that
warning is expected and should not clutter the test output.
* Raise required unit test coverage to 100%
* Remove unused param in publish flow controller
parthea pushed a commit that referenced this pull request Mar 9, 2026
* feat(spanner): add processing_units to Instance resource
PiperOrigin-RevId: 378758342
Source-Link: googleapis/googleapis@d869871
Source-Link: googleapis/googleapis-gen@54cfa76
* 🦉 Updates from OwlBot
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Mar 9, 2026
* feat: grab repository metadata
* feat: do not generate summary pages if metadata not found
* feat: address review comments
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storageIssues related to the Cloud Storage API.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can not "get_contents_as_*" when key is in a folder

3 participants

@tseaver@coveralls@dhermes