Revert "RPC retries (second PR) (#3324)"

[theacodes]

This reverts commit 67f4ba4.

This is due to system test failures

• https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2477
• https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2466

We're happy to reconsider the PR that we reverted, but it must not break the build.

[dhermes]

LGTM

[dhermes]

@jonparrott It's probably easier if we make a branch with the "broken" code already in, and then @calpeyser or someone else can send a PR to fix that branch?

[theacodes]

@dhermes you / they can do that by starting a new branch from master and cherry-picking 67f4ba4:

git checkout master
git pull
git checkout -b new-pr-for-retries
git cherry-pick 67f4ba4

[dhermes]

@jonparrott I'm OK with just the current master: 14e570a

Why get fancy?

[dhermes]

I made https://github.com/GoogleCloudPlatform/google-cloud-python/tree/pr-3324-to-fix

[dhermes]

CircleCI is green, let's merge this puppy?

[theacodes]

Why get fancy?

cherry-picking places the changes on top of the current master instead of being based on the past (which will be important when we merge the operation future stuff)

[dhermes]

OK, on it.

[dhermes]

Done. After I cherry-picked I git commit --amend-ed so the commit message ("Adding RPC retries to Bigtable.") was a bit more useful / didn't reference a PR ID.

[theacodes]

OK, on it.

Don't do it until #3623 is merged

[dhermes]

I shall garden away on the pr-3324-to-fix branch

[dhermes]

Rebase went smoothly 👍

[dhermes]

@calpeyser@garye@mbrukman FYI #3324 has been reverted and the contents (which need fixing, e.g. because they broken the Bigtable system tests) are in the pr-3324-to-fix branch

[mbrukman]

Thanks for the heads up, @dhermes! For our future reference, how does one run all the tests that Circle CI will run after submit? Is it just running nox at the top of tree, or in the bigtable dir for a single service?

[tseaver]

@mbrukman one needs to run nox with the appropriate environment variables set to configure system account credentials (GOOGLE_APPLICATION_CREDENTIALS, GOOGLE_CLOUD_TESTS_PROJECT_ID, GOOGLE_CLOUD_PROJECT). E.g.:

$ . /path/to/configure_my_credentials.sh
$ cd /path/to/google-cloud-python/bigtable
$ nox

[theacodes]

FYI: we're working on a more comprehensive retry story for this library.

[mbrukman]

@dhermes — were you planning to address the build issues in the pr-3324-to-fix branch, or are you looking to us to fix it?

@jonparrott — will that work on a more comprehensive retry story remove the need for this change for Bigtable, or should we still re-submit this change anyway, and that will be a more generic change that we might incorporate into the Bigtable library at some point in the future?

[dhermes]

were you planning to address the build issues in the pr-3324-to-fix branch

Sorry for miscommunicating here. I unfortunately do not have cycles for this.

[theacodes]

will that work on a more comprehensive retry story remove the need for this change for Bigtable

My hope is that the work will provide the foundation for adding retries to all libraries, at which point we can revisit this change. I'd love to work with you to validate the new functionality and get it into BigTable.

[garye]

@jonparrott That's an exciting development. Please keep us looped in!