Skip to content

Translate GA - #3650

Merged
lukesneeringer merged 5 commits into
googleapis:masterfrom
lukesneeringer:translate
Jul 21, 2017
Merged

Translate GA#3650
lukesneeringer merged 5 commits into
googleapis:masterfrom
lukesneeringer:translate

Conversation

@lukesneeringer

@lukesneeringerlukesneeringer commented Jul 21, 2017

Copy link
Copy Markdown
Contributor

This pull request bumps Translate to GA status, and should be followed by a release.

There are a couple of last minute changes:

  • The actual surface is moved from translate to translate_v2, with a alias in translate.
  • Documentation on models is changed to encourage the use of a string, rather than the constants.

Luke Sneeringer added 4 commits July 13, 2017 13:57
Luke Sneeringer
Translate GA.
1c043a0
This commit does two things:
* Moves the library proper into a versioned namespace.
* Removes the BASE/NMT enum; the API producers want this to be a plain string.
And then it flips the version number to 1.0.
Luke Sneeringer
Restore the BASE and NMT constants at google.cloud.translate.
95e5581
Luke Sneeringer
Merge branch 'public-master' into translate
a20dfdb
Luke Sneeringer
Update README
2cebc8b
@lukesneeringerlukesneeringer self-assigned this Jul 21, 2017
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 21, 2017
lukesneeringer
lukesneeringer commented Jul 21, 2017
View reviewed changes
Comment threadpubsub/nox.py
session.virtualenv_dirname = 'unit-' + python_version

# Install all test dependencies, then install this package in-place.
session.install('mock', 'pytest', 'pytest-cov', *LOCAL_DEPS)

This comment was marked as spam.

Sign in to view

dhermes
dhermes approved these changes Jul 21, 2017
View reviewed changes

@dhermesdhermes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukesneeringer I'm surprised there are so few changes here. What am I missing?

LGTM

Comment threadtranslate/google/cloud/translate_v2/client.py
:param model: (Optional) The model used to translate the text. The
only accepted values are :attr:`BASE` and :attr:`NMT`.
:param model: (Optional) The model used to translate the text, such
as ``'base'`` or ``'nmt'``.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadtranslate/setup.py
setup(
name='google-cloud-translate',
version='0.25.0',
version='1.0.0',

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadtranslate/tests/system.py
'Me llamo Jeff', 'My name is Jeff']
translations = Config.CLIENT.translate(
values, target_language='de', model=translate.NMT)
values, target_language='de', model='nmt')

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@lukesneeringer
lukesneeringer merged commit d2bc36d into googleapis:masterJul 21, 2017
@lukesneeringer
lukesneeringer deleted the translate branch July 21, 2017 21:50
@dhermesdhermes mentioned this pull request Aug 4, 2017
Merged
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@lukesneeringer@landrito
Translate GA (googleapis#3650)
77c9176
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@lukesneeringer@landrito
Translate GA (googleapis#3650)
30f98f7
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@lukesneeringer@landrito
Translate GA (googleapis#3650)
e3bef45
parthea pushed a commit that referenced this pull request Oct 21, 2023
@lukesneeringer
Translate GA (#3650)
729564d
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tseavertseaverAwaiting requested review from tseaver
1 more reviewer
@dhermesdhermesdhermes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lukesneeringerlukesneeringer

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lukesneeringer@dhermes@googlebot