Skip to content

Removing get_credentials() from core. - #3667

Merged
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:remove-get_credentials
Jul 25, 2017
Merged

Removing get_credentials() from core.#3667
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:remove-get_credentials

Conversation

@dhermes

Copy link
Copy Markdown
Contributor

In the process also:

  • Slight re-org on nox.py config (to pass posargs) for core and datastore
  • Getting rid of last usage of _Monkey in datastore

This is part of @jonparrott's effort to slim down / stabilize core.


Temporarily labeled "do not merge" so we can discuss "churn" first.

@dhermesdhermes added api: bigtable Issues related to the Bigtable API. api: datastore Issues related to the Datastore API. api: spanner Issues related to the Spanner API. api: core do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jul 25, 2017
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 25, 2017
raise ValueError(_GOOGLE_AUTH_CREDENTIALS_HELP)
if credentials is None and _http is None:
credentials = get_credentials()
credentials, _ = google.auth.default()

This comment was marked as spam.

This comment was marked as spam.

In the process also:
- Slight re-org on `nox.py` config (to pass posargs) for `core`
and `datastore`
- Getting rid of last usage of `_Monkey` in datastore
This is part of `@jonparrott`'s effort to slim down / stabilize
`core`.
@dhermes
dhermesforce-pushed the remove-get_credentials branch from f040a4e to bca6b7aCompareJuly 25, 2017 20:13
@dhermes

Copy link
Copy Markdown
ContributorAuthor

Rebased after #3668 was merged (so now google.cloud.credentials is gone)

@dhermes
dhermes merged commit 2083542 into googleapis:masterJul 25, 2017
@dhermes
dhermes deleted the remove-get_credentials branch July 25, 2017 21:13
@dhermesdhermes removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 25, 2017
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
* Removing `get_credentials()` from `core`.
In the process also:
- Slight re-org on `nox.py` config (to pass posargs) for `core`
and `datastore`
- Getting rid of last usage of `_Monkey` in datastore
This is part of `@jonparrott`'s effort to slim down / stabilize
`core`.
* Removing `google.cloud.credentials` module from docs.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
* Removing `get_credentials()` from `core`.
In the process also:
- Slight re-org on `nox.py` config (to pass posargs) for `core`
and `datastore`
- Getting rid of last usage of `_Monkey` in datastore
This is part of `@jonparrott`'s effort to slim down / stabilize
`core`.
* Removing `google.cloud.credentials` module from docs.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
* Removing `get_credentials()` from `core`.
In the process also:
- Slight re-org on `nox.py` config (to pass posargs) for `core`
and `datastore`
- Getting rid of last usage of `_Monkey` in datastore
This is part of `@jonparrott`'s effort to slim down / stabilize
`core`.
* Removing `google.cloud.credentials` module from docs.
parthea pushed a commit that referenced this pull request Nov 22, 2025
* Removing `get_credentials()` from `core`.
In the process also:
- Slight re-org on `nox.py` config (to pass posargs) for `core`
and `datastore`
- Getting rid of last usage of `_Monkey` in datastore
This is part of `@jonparrott`'s effort to slim down / stabilize
`core`.
* Removing `google.cloud.credentials` module from docs.
parthea pushed a commit that referenced this pull request Nov 24, 2025
* Removing `get_credentials()` from `core`.
In the process also:
- Slight re-org on `nox.py` config (to pass posargs) for `core`
and `datastore`
- Getting rid of last usage of `_Monkey` in datastore
This is part of `@jonparrott`'s effort to slim down / stabilize
`core`.
* Removing `google.cloud.credentials` module from docs.
parthea pushed a commit that referenced this pull request Nov 24, 2025
* Removing `get_credentials()` from `core`.
In the process also:
- Slight re-org on `nox.py` config (to pass posargs) for `core`
and `datastore`
- Getting rid of last usage of `_Monkey` in datastore
This is part of `@jonparrott`'s effort to slim down / stabilize
`core`.
* Removing `google.cloud.credentials` module from docs.
parthea pushed a commit that referenced this pull request Mar 9, 2026
* Removing `get_credentials()` from `core`.
In the process also:
- Slight re-org on `nox.py` config (to pass posargs) for `core`
and `datastore`
- Getting rid of last usage of `_Monkey` in datastore
This is part of `@jonparrott`'s effort to slim down / stabilize
`core`.
* Removing `google.cloud.credentials` module from docs.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtableIssues related to the Bigtable API.api: coreapi: datastoreIssues related to the Datastore API.api: spannerIssues related to the Spanner API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@dhermes@tseaver@theacodes@lukesneeringer@googlebot