Uh oh!
There was an error while loading. Please reload this page.
Prep langauge-0.26.0 release. - #3680
Conversation
| setup( | ||
| name='google-cloud-language', | ||
| version='0.25.0', | ||
| version='0.26.0', |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
lukesneeringer
left a comment
There was a problem hiding this comment.
Approved. It is fine to release this first (it is more urgent) and then do the metapackage.
lukesneeringer
commented
Jul 26, 2017
Let me know if anything blocks this. (DPE is waiting on it to publish their work.) |
tseaver
commented
Jul 26, 2017
@lukesneeringer the /var/code/gcp/docs/language/gapic/v1/api.rst:4: (WARNING/2) autodoc: failedtoimportmodule'google.cloud.language_v1'; thefollowingexceptionwasraised:
Traceback (mostrecentcalllast):
File"/var/code/gcp/.nox/docs/lib/python3.6/site-packages/sphinx/ext/autodoc.py", line657, inimport_object__import__(self.modname)
ModuleNotFoundError: Nomodulenamed'google.cloud.language_v1' |
lukesneeringer
commented
Jul 26, 2017
I think that is a chicken and egg problem, because docs installs the released packages. @dhermes, is that accurate? |
dhermes
commented
Jul 26, 2017
@lukesneeringer That is not accurate. |
lukesneeringer
commented
Jul 26, 2017
Bah, okay, I will look into it. I built them locally repeatedly. |
dhermes
commented
Jul 26, 2017
@lukesneeringer It was broken by #3512 and is being fixed by #3683 |
lukesneeringer
commented
Jul 27, 2017
Ah. I can not wait until our packages do not pollute one another. |
lukesneeringer
commented
Jul 27, 2017
It turned out this was a chocobo and egg problem after all, but in a way that is easy to fix. The Noxfile had: session.install(
'core/', 'bigquery/', 'bigtable/', 'datastore/', 'dns/', 'language/',
'logging/', 'error_reporting/', 'monitoring/', 'pubsub/',
'resource_manager/', 'runtimeconfig/', 'spanner/', 'speech/',
'storage/', 'trace/', 'translate/', 'vision/',
)
session.install('-e', '.')The second line plowed over the local installs in the first line. |
lukesneeringer
commented
Jul 27, 2017
Note: The last commit is a cherry-pick from #3688. There will be no translate changes in this PR once that hits master. |
tseaver
commented
Jul 27, 2017
The generated $ ll .nox/docs/lib/python3.6/site-packages/google/cloud/
total 212
drwxrwxr-x 26 tseaver tseaver 4096 Jul 27 09:29 ./
drwxrwxr-x 15 tseaver tseaver 4096 Jul 27 09:29 ../
drwxrwxr-x 4 tseaver tseaver 4096 Jul 27 09:29 bigquery/
drwxrwxr-x 4 tseaver tseaver 4096 Jul 27 09:29 bigtable/
-rw-rw-r-- 1 tseaver tseaver 8726 Jul 26 15:45 client.py
-rw-rw-r-- 1 tseaver tseaver 7605 Dec 3 2016 credentials.py
drwxrwxr-x 3 tseaver tseaver 4096 Jul 27 09:29 datastore/
drwxrwxr-x 3 tseaver tseaver 4096 Jul 27 09:29 dns/
-rw-rw-r-- 1 tseaver tseaver 1319 Dec 3 2016 environment_vars.py
drwxrwxr-x 3 tseaver tseaver 4096 Jul 27 09:29 error_reporting/
-rw-rw-r-- 1 tseaver tseaver 6672 Jul 25 14:12 exceptions.py
drwxrwxr-x 3 tseaver tseaver 4096 Jul 27 09:29 future/
drwxrwxr-x 12 tseaver tseaver 4096 Jul 27 09:29 gapic/
-rw-rw-r-- 1 tseaver tseaver 19641 Jul 25 14:12 _helpers.py
-rw-rw-r-- 1 tseaver tseaver 11441 Jul 25 14:12 _http.py
-rw-rw-r-- 1 tseaver tseaver 6879 Jul 25 14:12 iam.py
-rw-rw-r-- 1 tseaver tseaver 15781 Jul 25 14:12 iterator.py
drwxrwxr-x 3 tseaver tseaver 4096 Jul 27 09:29 language/
drwxrwxr-x 4 tseaver tseaver 4096 Jul 27 09:29 logging/
drwxrwxr-x 3 tseaver tseaver 4096 Jul 27 09:29 monitoring/
-rw-rw-r-- 1 tseaver tseaver 9082 Jul 25 14:12 operation.py
drwxrwxr-x 10 tseaver tseaver 4096 Jul 27 09:29 proto/
drwxrwxr-x 3 tseaver tseaver 4096 Jul 27 09:29 pubsub/
drwxrwxr-x 2 tseaver tseaver 4096 Jul 27 09:29 __pycache__/
drwxrwxr-x 3 tseaver tseaver 4096 Jul 27 09:29 resource_manager/
drwxrwxr-x 3 tseaver tseaver 4096 Jul 27 09:29 runtimeconfig/
drwxrwxr-x 3 tseaver tseaver 4096 Jul 27 09:29 spanner/
drwxrwxr-x 3 tseaver tseaver 4096 Jul 27 09:29 speech/
drwxrwxr-x 3 tseaver tseaver 4096 Jul 27 09:29 speech_v1/
drwxrwxr-x 3 tseaver tseaver 4096 Jul 27 09:29 storage/
drwxrwxr-x 3 tseaver tseaver 4096 Jul 27 09:29 streaming/
-rw-rw-r-- 1 tseaver tseaver 3435 Jul 25 14:12 _testing.py
drwxrwxr-x 3 tseaver tseaver 4096 Jul 27 09:29 translate/
-rw-rw-r-- 1 tseaver tseaver 923 Jul 27 09:29 videointelligence.py
drwxrwxr-x 3 tseaver tseaver 4096 Jul 27 09:29 videointelligence_v1beta1/
drwxrwxr-x 3 tseaver tseaver 4096 Jul 27 09:29 vision/
drwxrwxr-x 3 tseaver tseaver 4096 Jul 27 09:29 vision_v1/ |
lukesneeringer
commented
Jul 27, 2017
@tseaver Are you sure? It builds correctly on CI now (once trace and translate are fixed). |
tseaver
commented
Jul 27, 2017
I would argue that the |
tseaver
commented
Jul 27, 2017
@lukesneeringer I hadn't pulled your changes in. It is building cleanly now on my local machine. How do you want to handle ordering this one and #3688? |
lukesneeringer
commented
Jul 27, 2017
I just merged #3688. I propose we merge |
lukesneeringer
commented
Jul 27, 2017
It totally is, but the build fails without it (as you noted on #3688). Regardless, we can do that separately later. |
tseaver
commented
Jul 27, 2017
Rebased, removing all the stuff from #3688. I will merge when green and tag. |
tseaver
commented
Jul 27, 2017
Automated PyPI push wins! |
dhermes
commented
Jul 27, 2017
Is it worth continuing pushing versions to |
lukesneeringer
commented
Jul 27, 2017
Does PyPI (or warehouse) have any way to redirect a package? In a perfect world I would like to make it so |
dhermes
commented
Jul 27, 2017
AFAIK no, but I'll let @jonparrott have the final word on that |
All except the last (PR #3679) are internal / housekeeping / testing. So, draft release notes:
google-cloud-language 0.26.0