Skip to content

Using HTTPS wikipedia links in language system tests. - #3732

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:fix-3731
Aug 5, 2017
Merged

Using HTTPS wikipedia links in language system tests.#3732
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:fix-3731

Conversation

@dhermes

Copy link
Copy Markdown
Contributor

Fixes#3731.

Also relaxing the sentiment score expected range for "Jogging is fun" (the same backend update that changed HTTP to HTTPS changed the score from 0.5 to 0.7).

Also updating the language usage doc with the correct (and HTTPS) URLs for the 3 examples.

Fixesgoogleapis#3731.
Also relaxing the sentiment score expected range for
"Jogging is fun" (the same backend update that changed HTTP to
HTTPS changed the score from 0.5 to 0.7).
Also updating the language usage doc with the correct (and HTTPS)
URLs for the 3 examples.
@dhermesdhermes added api: language Issues related to the Cloud Natural Language API API. build testing labels Aug 5, 2017
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 5, 2017
@dhermes

Copy link
Copy Markdown
ContributorAuthor

I am going to "aggressively merge preemptively" here. I REALLY want a green build.

@dhermes
dhermes merged commit 3012b5e into googleapis:masterAug 5, 2017
@dhermes
dhermes deleted the fix-3731 branch August 5, 2017 00:16
@dhermes

Copy link
Copy Markdown
ContributorAuthor

ZOMG GREEEEEEEN! https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2736

🎉 🎈 ⚡ 🚀 🐼

landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
Fixesgoogleapis#3731.
Also relaxing the sentiment score expected range for
"Jogging is fun" (the same backend update that changed HTTP to
HTTPS changed the score from 0.5 to 0.7).
Also updating the language usage doc with the correct (and HTTPS)
URLs for the 3 examples.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
Fixesgoogleapis#3731.
Also relaxing the sentiment score expected range for
"Jogging is fun" (the same backend update that changed HTTP to
HTTPS changed the score from 0.5 to 0.7).
Also updating the language usage doc with the correct (and HTTPS)
URLs for the 3 examples.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
Fixesgoogleapis#3731.
Also relaxing the sentiment score expected range for
"Jogging is fun" (the same backend update that changed HTTP to
HTTPS changed the score from 0.5 to 0.7).
Also updating the language usage doc with the correct (and HTTPS)
URLs for the 3 examples.
parthea pushed a commit that referenced this pull request Jul 6, 2023
Fixes#3731.
Also relaxing the sentiment score expected range for
"Jogging is fun" (the same backend update that changed HTTP to
HTTPS changed the score from 0.5 to 0.7).
Also updating the language usage doc with the correct (and HTTPS)
URLs for the 3 examples.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: languageIssues related to the Cloud Natural Language API API.cla: yesThis human has signed the Contributor License Agreement.testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes@lukesneeringer@tseaver@googlebot