Skip to content

BigQuery: Remove client-side enum validation. - #3735

Merged
lukesneeringer merged 1 commit into
googleapis:masterfrom
lukesneeringer:issue-3725
Aug 7, 2017
Merged

BigQuery: Remove client-side enum validation.#3735
lukesneeringer merged 1 commit into
googleapis:masterfrom
lukesneeringer:issue-3725

Conversation

@lukesneeringer

@lukesneeringerlukesneeringer commented Aug 7, 2017

Copy link
Copy Markdown
Contributor

Fixes#3725.

@lukesneeringerlukesneeringer self-assigned this Aug 7, 2017
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 7, 2017
dhermes
dhermes approved these changes Aug 7, 2017
View reviewed changes

@dhermesdhermes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadbigquery/tests/unit/test__helpers.py

class Sub(self._get_target_class()):
ALLOWED = ('FOO', 'BAR', 'BAZ')
pass

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@lukesneeringer
lukesneeringer merged commit b09eda9 into googleapis:masterAug 7, 2017
@lukesneeringer
lukesneeringer deleted the issue-3725 branch August 7, 2017 16:16
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@lukesneeringer@landrito
BigQuery: Remove client-side enum validation. (googleapis#3735)
2fe57c1
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@lukesneeringer@landrito
BigQuery: Remove client-side enum validation. (googleapis#3735)
f206acd
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@lukesneeringer@landrito
BigQuery: Remove client-side enum validation. (googleapis#3735)
a1f9bc7
@lukesneeringerlukesneeringer mentioned this pull request Aug 24, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tseavertseaverAwaiting requested review from tseaver
1 more reviewer
@dhermesdhermesdhermes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lukesneeringerlukesneeringer

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lukesneeringer@tseaver@dhermes@googlebot