Skip to content

Make exclude_from_indexes a set, and public API. - #3756

Merged
lukesneeringer merged 1 commit into
googleapis:masterfrom
lukesneeringer:issue-3508
Aug 8, 2017
Merged

Make exclude_from_indexes a set, and public API.#3756
lukesneeringer merged 1 commit into
googleapis:masterfrom
lukesneeringer:issue-3508

Conversation

@lukesneeringer

Copy link
Copy Markdown
Contributor

Tagging everyone for review since I want to make sure nobody objects.

Note: This is a breaking change for anyone who previously relied on the private _exclude_from_indexes. I still consider it to be semver-minor since this was marked private.

Fixes#3508.

@lukesneeringerlukesneeringer self-assigned this Aug 8, 2017
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 8, 2017

@dhermesdhermes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukesneeringer
lukesneeringer merged commit 1ff7708 into googleapis:masterAug 8, 2017
@lukesneeringer
lukesneeringer deleted the issue-3508 branch August 8, 2017 19:37
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@lukesneeringer@dhermes@googlebot