Skip to content

Fix __eq__ and __ne__. - #3765

Merged
lukesneeringer merged 5 commits into
googleapis:masterfrom
lukesneeringer:issue-3455
Aug 8, 2017
Merged

Fix __eq__ and __ne__.#3765
lukesneeringer merged 5 commits into
googleapis:masterfrom
lukesneeringer:issue-3455

Conversation

@lukesneeringer

@lukesneeringerlukesneeringer commented Aug 8, 2017

Copy link
Copy Markdown
Contributor

This updates __eq__ to do type-checking correctly on all classes (except mock classes defined in unit test modules):

def __eq__(self, other):
if not isinstance(other, type(self)):
return NotImplemented

It also updates __ne__ to be exactly:

def __ne__(self, other):
return not self == other

Fixes#3455.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 8, 2017
dhermes
dhermes reviewed Aug 8, 2017
View reviewed changes
Comment threadbigquery/google/cloud/bigquery/_helpers.py
self.value == other.value)

def __ne__(self, other):
return not self == other

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes
dhermes reviewed Aug 8, 2017
View reviewed changes
Comment threadbigquery/google/cloud/bigquery/schema.py
return self._key() != other._key()
else:
return NotImplemented
return not self == other

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes

dhermes commented Aug 8, 2017

Copy link
Copy Markdown
Contributor

LGTM

@lukesneeringer
lukesneeringer merged commit b242099 into googleapis:masterAug 8, 2017
@lukesneeringer
lukesneeringer deleted the issue-3455 branch August 8, 2017 21:51
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@lukesneeringer@landrito
Fix __eq__ and __ne__. (googleapis#3765)
5238de1
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@lukesneeringer@landrito
Fix __eq__ and __ne__. (googleapis#3765)
347ed4b
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@lukesneeringer@landrito
Fix __eq__ and __ne__. (googleapis#3765)
d6b1a7a
This was referenced Aug 24, 2017
Merged
Merged
@dhermesdhermes mentioned this pull request Aug 24, 2017
Merged
@lukesneeringerlukesneeringer mentioned this pull request Aug 24, 2017
Merged
@dhermesdhermes mentioned this pull request Aug 24, 2017
Merged
parthea pushed a commit that referenced this pull request Oct 21, 2023
Takashi Matsuo@busunkim96
[container-registry] fix: mark a flaky test [(#3765)](GoogleCloudPlat…
2a2a7b2
…form/python-docs-samples#3765)
fixes#2894
parthea pushed a commit that referenced this pull request Oct 21, 2023
@lukesneeringer
Fix __eq__ and __ne__. (#3765)
b24ff84
parthea pushed a commit that referenced this pull request Nov 22, 2025
@lukesneeringer
Fix __eq__ and __ne__. (#3765)
6588d35
parthea pushed a commit that referenced this pull request Nov 24, 2025
@lukesneeringer
Fix __eq__ and __ne__. (#3765)
546d7ff
parthea pushed a commit that referenced this pull request Mar 9, 2026
@lukesneeringer
Fix __eq__ and __ne__. (#3765)
6797d05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tseavertseaverAwaiting requested review from tseaver
1 more reviewer
@dhermesdhermesdhermes left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lukesneeringer@dhermes@googlebot