Skip to content

Wait for load jobs to complete in system tests. - #3782

Merged
lukesneeringer merged 3 commits into
googleapis:masterfrom
tswast:bq-3742-flake
Aug 11, 2017
Merged

Wait for load jobs to complete in system tests.#3782
lukesneeringer merged 3 commits into
googleapis:masterfrom
tswast:bq-3742-flake

Conversation

@tswast

@tswasttswast commented Aug 9, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

Specify job ID in BQ DB-API DML tests to allow for further test flake
debugging.

Attempting to debug #3742

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 9, 2017
@tswast

tswast commented Aug 9, 2017

Copy link
Copy Markdown
ContributorAuthor

On closer look, the job.result() calls might be redundant.

@lukesneeringer

lukesneeringer commented Aug 10, 2017

Copy link
Copy Markdown
Contributor

@tswast Do you want this merged?

dhermes
dhermes reviewed Aug 10, 2017
View reviewed changes
Comment threadbigquery/tests/system.py Outdated
Config.CURSOR.execute(query_template.format(dataset_name, table_name))
Config.CURSOR.execute(
query_template.format(dataset_name, table_name),
job_id='test_dbapi_w_dml_{}'.format(str(uuid.uuid4())))

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tswasttswast changed the title BQ: wait for load jobs to complete in system tests.DO_NOT_MERGE BQ: wait for load jobs to complete in system tests.Aug 10, 2017
@lukesneeringer

lukesneeringer commented Aug 10, 2017

Copy link
Copy Markdown
Contributor

That answers that. :-)

@lukesneeringerlukesneeringer added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 10, 2017
@lukesneeringerlukesneeringer changed the title DO_NOT_MERGE BQ: wait for load jobs to complete in system tests.Wait for load jobs to complete in system tests.Aug 10, 2017
@lukesneeringerlukesneeringer added the api: bigquery Issues related to the BigQuery API. label Aug 10, 2017
@tswasttswast removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 10, 2017
@tswast

tswast commented Aug 10, 2017

Copy link
Copy Markdown
ContributorAuthor

I updated the .result() futures API calls to have a 2 minute timeout rather than potentially hang forever. I think the .result() was redundant with the retry until job done calls, so I removed those, too.

@lukesneeringer
lukesneeringer merged commit 5145022 into googleapis:masterAug 11, 2017
@tswast
tswast deleted the bq-3742-flake branch August 11, 2017 15:32
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@tswast@landrito
Wait for load jobs to complete in system tests. (googleapis#3782)
9c23e57
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@tswast@landrito
Wait for load jobs to complete in system tests. (googleapis#3782)
7ced18b
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@tswast@landrito
Wait for load jobs to complete in system tests. (googleapis#3782)
066f540
@lukesneeringerlukesneeringer mentioned this pull request Aug 24, 2017
Merged
parthea pushed a commit that referenced this pull request Nov 24, 2025
@arithmetic1728Bill Prin
Jon Wayne Parrott@dpebot@waprinmichaelawyu@andrewsg@frankyn@engelke@gguuss@kurtisvg@dmahugh@renovate-bot@leahecole
chore: move samples from python-docs-sample (#18)
3b5a4de
* Add Error Reporting Code
* Updating doc links [(#324)](GoogleCloudPlatform/python-docs-samples#324)
* Commenting noxfile, renaming a test file.
Change-Id: Ice25caa7c035c24a585a66575dda69e170862df8
* Update requirements. [(#436)](GoogleCloudPlatform/python-docs-samples#436)
* Fix import order lint errors
Change-Id: Ieaf7237fc6f925daec46a07d2e81a452b841198a
* bump
Change-Id: I02e7767d13ba267ee9fc72c5b68a57013bb8b8d3
* Auto-update dependencies. [(#537)](GoogleCloudPlatform/python-docs-samples#537)
* Update samples to support latest Google Cloud Python [(#656)](GoogleCloudPlatform/python-docs-samples#656)
* Switch Error Reporting to Google Cloud Python [(#663)](GoogleCloudPlatform/python-docs-samples#663)
* Switch Error Reporting to Google Cloud Python
* Switch Error Reporting to Google Cloud Python
* Auto-update dependencies. [(#715)](GoogleCloudPlatform/python-docs-samples#715)
* Auto-update dependencies. [(#914)](GoogleCloudPlatform/python-docs-samples#914)
* Auto-update dependencies.
* xfail the error reporting test
* Fix lint
* Re-generate all readmes
* Auto-update dependencies. [(#922)](GoogleCloudPlatform/python-docs-samples#922)
* Auto-update dependencies.
* Fix pubsub iam samples
* Fix README rst links [(#962)](GoogleCloudPlatform/python-docs-samples#962)
* Fix README rst links
* Update all READMEs
* Auto-update dependencies. [(#1004)](GoogleCloudPlatform/python-docs-samples#1004)
* Auto-update dependencies.
* Fix natural language samples
* Fix pubsub iam samples
* Fix language samples
* Fix bigquery samples
* Auto-update dependencies. [(#1011)](GoogleCloudPlatform/python-docs-samples#1011)
* Auto-update dependencies. [(#1055)](GoogleCloudPlatform/python-docs-samples#1055)
* Auto-update dependencies.
* Explicitly use latest bigtable client
Change-Id: Id71e9e768f020730e4ca9514a0d7ebaa794e7d9e
* Revert language update for now
Change-Id: I8867f154e9a5aae00d0047c9caf880e5e8f50c53
* Remove pdb. smh
Change-Id: I5ff905fadc026eebbcd45512d4e76e003e3b2b43
* Auto-update dependencies. [(#1093)](GoogleCloudPlatform/python-docs-samples#1093)
* Auto-update dependencies.
* Fix storage notification poll sample
Change-Id: I6afbc79d15e050531555e4c8e51066996717a0f3
* Fix spanner samples
Change-Id: I40069222c60d57e8f3d3878167591af9130895cb
* Drop coverage because it's not useful
Change-Id: Iae399a7083d7866c3c7b9162d0de244fbff8b522
* Try again to fix flaky logging test
Change-Id: I6225c074701970c17c426677ef1935bb6d7e36b4
* Update all generated readme auth instructions [(#1121)](GoogleCloudPlatform/python-docs-samples#1121)
Change-Id: I03b5eaef8b17ac3dc3c0339fd2c7447bd3e11bd2
* Added Link to Python Setup Guide [(#1158)](GoogleCloudPlatform/python-docs-samples#1158)
* Update Readme.rst to add Python setup guide
As requested in b/64770713.
This sample is linked in documentation https://cloud.google.com/bigtable/docs/scaling, and it would make more sense to update the guide here than in the documentation.
* Update README.rst
* Update README.rst
* Update README.rst
* Update README.rst
* Update README.rst
* Update install_deps.tmpl.rst
* Updated readmegen scripts and re-generated related README files
* Fixed the lint error
* Auto-update dependencies. [(#1186)](GoogleCloudPlatform/python-docs-samples#1186)
* Add error reporting sample for manual reporting
* Readd fluentd samples
* rename dir
* Auto-update dependencies. [(#1205)](GoogleCloudPlatform/python-docs-samples#1205)
* Auto-update dependencies. [(#1215)](GoogleCloudPlatform/python-docs-samples#1215)
* Auto-update dependencies. [(#1245)](GoogleCloudPlatform/python-docs-samples#1245)
* Auto-update dependencies. [(#1248)](GoogleCloudPlatform/python-docs-samples#1248)
* Added "Open in Cloud Shell" buttons to README files [(#1254)](GoogleCloudPlatform/python-docs-samples#1254)
* Auto-update dependencies. [(#1276)](GoogleCloudPlatform/python-docs-samples#1276)
* Auto-update dependencies. [(#1282)](GoogleCloudPlatform/python-docs-samples#1282)
* Auto-update dependencies.
* Fix storage acl sample
Change-Id: I413bea899fdde4c4859e4070a9da25845b81f7cf
* Auto-update dependencies. [(#1317)](GoogleCloudPlatform/python-docs-samples#1317)
* Auto-update dependencies. [(#1320)](GoogleCloudPlatform/python-docs-samples#1320)
* Auto-update dependencies. [(#1359)](GoogleCloudPlatform/python-docs-samples#1359)
* Auto-update dependencies. [(#1377)](GoogleCloudPlatform/python-docs-samples#1377)
* Auto-update dependencies.
* Update requirements.txt
* Regenerate the README files and fix the Open in Cloud Shell link for some samples [(#1441)](GoogleCloudPlatform/python-docs-samples#1441)
* Update READMEs to fix numbering and add git clone [(#1464)](GoogleCloudPlatform/python-docs-samples#1464)
* Auto-update dependencies. [(#1658)](GoogleCloudPlatform/python-docs-samples#1658)
* Auto-update dependencies.
* Rollback appengine/standard/bigquery/.
* Rollback appengine/standard/iap/.
* Rollback bigtable/metricscaler.
* Rolledback appengine/flexible/datastore.
* Rollback dataproc/
* Rollback jobs/api_client
* Rollback vision/cloud-client.
* Rollback functions/ocr/app.
* Rollback iot/api-client/end_to_end_example.
* Rollback storage/cloud-client.
* Rollback kms/api-client.
* Rollback dlp/
* Rollback bigquery/cloud-client.
* Rollback iot/api-client/manager.
* Rollback appengine/flexible/cloudsql_postgresql.
* Put in new region code error_reporting_quickstart [(#1842)](GoogleCloudPlatform/python-docs-samples#1842)
* New region tags [(#1843)](GoogleCloudPlatform/python-docs-samples#1843)
* Auto-update dependencies. [(#1980)](GoogleCloudPlatform/python-docs-samples#1980)
* Auto-update dependencies.
* Update requirements.txt
* Update requirements.txt
* Adds updates including compute [(#2436)](GoogleCloudPlatform/python-docs-samples#2436)
* Adds updates including compute
* Python 2 compat pytest
* Fixing weird \r\n issue from GH merge
* Put asset tests back in
* Re-add pod operator test
* Hack parameter for k8s pod operator
* Auto-update dependencies. [(#2005)](GoogleCloudPlatform/python-docs-samples#2005)
* Auto-update dependencies.
* Revert update of appengine/flexible/datastore.
* revert update of appengine/flexible/scipy
* revert update of bigquery/bqml
* revert update of bigquery/cloud-client
* revert update of bigquery/datalab-migration
* revert update of bigtable/quickstart
* revert update of compute/api
* revert update of container_registry/container_analysis
* revert update of dataflow/run_template
* revert update of datastore/cloud-ndb
* revert update of dialogflow/cloud-client
* revert update of dlp
* revert update of functions/imagemagick
* revert update of functions/ocr/app
* revert update of healthcare/api-client/fhir
* revert update of iam/api-client
* revert update of iot/api-client/gcs_file_to_device
* revert update of iot/api-client/mqtt_example
* revert update of language/automl
* revert update of run/image-processing
* revert update of vision/automl
* revert update testing/requirements.txt
* revert update of vision/cloud-client/detect
* revert update of vision/cloud-client/product_search
* revert update of jobs/v2/api_client
* revert update of jobs/v3/api_client
* revert update of opencensus
* revert update of translate/cloud-client
* revert update to speech/cloud-client
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Co-authored-by: Doug Mahugh <dmahugh@gmail.com>
* chore(deps): update dependency fluent-logger to v0.9.5 [(#3004)](GoogleCloudPlatform/python-docs-samples#3004)
* chore(deps): update dependency fluent-logger to v0.9.6 [(#3080)](GoogleCloudPlatform/python-docs-samples#3080)
This PR contains the following updates:
| Package | Update | Change |
|---|---|---|
| [fluent-logger](https://togithub.com/fluent/fluent-logger-python) | patch | `==0.9.5` -> `==0.9.6` |
---
### Release Notes
<details>
<summary>fluent/fluent-logger-python</summary>
### [`v0.9.6`](https://togithub.com/fluent/fluent-logger-python/compare/v0.9.5...v0.9.6)
[Compare Source](https://togithub.com/fluent/fluent-logger-python/compare/v0.9.5...v0.9.6)
</details>
---
### Renovate configuration
:date: **Schedule**: At any time (no schedule defined).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/python-docs-samples).
* Simplify noxfile setup. [(#2806)](GoogleCloudPlatform/python-docs-samples#2806)
* chore(deps): update dependency requests to v2.23.0
* Simplify noxfile and add version control.
* Configure appengine/standard to only test Python 2.7.
* Update Kokokro configs to match noxfile.
* Add requirements-test to each folder.
* Remove Py2 versions from everything execept appengine/standard.
* Remove conftest.py.
* Remove appengine/standard/conftest.py
* Remove 'no-sucess-flaky-report' from pytest.ini.
* Add GAE SDK back to appengine/standard tests.
* Fix typo.
* Roll pytest to python 2 version.
* Add a bunch of testing requirements.
* Remove typo.
* Add appengine lib directory back in.
* Add some additional requirements.
* Fix issue with flake8 args.
* Even more requirements.
* Readd appengine conftest.py.
* Add a few more requirements.
* Even more Appengine requirements.
* Add webtest for appengine/standard/mailgun.
* Add some additional requirements.
* Add workaround for issue with mailjet-rest.
* Add responses for appengine/standard/mailjet.
Co-authored-by: Renovate Bot <bot@renovateapp.com>
* chore(deps): update dependency google-cloud-error-reporting to v0.34.0 [(#3782)](GoogleCloudPlatform/python-docs-samples#3782)
* chore(deps): update dependency pytest to v5.4.3 [(#4279)](GoogleCloudPlatform/python-docs-samples#4279)
* chore(deps): update dependency pytest to v5.4.3
* specify pytest for python 2 in appengine
Co-authored-by: Leah Cole <coleleah@google.com>
* chore(deps): update dependency mock to v4 [(#4287)](GoogleCloudPlatform/python-docs-samples#4287)
* chore(deps): update dependency mock to v4
* specify mock version for appengine python 2
Co-authored-by: Leah Cole <coleleah@google.com>
* Update dependency pytest to v6 [(#4390)](GoogleCloudPlatform/python-docs-samples#4390)
* chore: update templates
Co-authored-by: Bill Prin <waprin@google.com>
Co-authored-by: Jon Wayne Parrott <jonwayne@google.com>
Co-authored-by: DPE bot <dpebot@google.com>
Co-authored-by: Bill Prin <waprin@gmail.com>
Co-authored-by: michaelawyu <chenyumic@google.com>
Co-authored-by: Andrew Gorcester <gorcester@google.com>
Co-authored-by: Andrew Gorcester <andrew.gorcester@gmail.com>
Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
Co-authored-by: Charles Engelke <github@engelke.com>
Co-authored-by: Gus Class <gguuss@gmail.com>
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Co-authored-by: Doug Mahugh <dmahugh@gmail.com>
Co-authored-by: WhiteSource Renovate <bot@renovateapp.com>
Co-authored-by: Leah Cole <coleleah@google.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@dhermesdhermesdhermes left review comments
@lukesneeringerlukesneeringerlukesneeringer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the BigQuery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tswast@lukesneeringer@dhermes@googlebot