Uh oh!
There was an error while loading. Please reload this page.
Drop 'Database.read' and 'Database.execute_sql' convenience methods. - #3787
Merged
Conversation
Because the context managers they use returned the session to the database's pool, application code could not safely iterate over the result sets returned by the methods. Update docs for 'Snapshot.read' and 'Snapshot.execute_sql' to emphasize iteration of their results sets before the session is returned to the database pool (i.e., within the 'with' block which constructs the snapshot). Closes#3769.
lukesneeringer
approved these changes
Aug 10, 2017
tseaver
commented
Aug 10, 2017
ContributorAuthor
Not waiting for appveyor. |
landrito pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 21, 2017
…oogleapis#3787) Because the context managers they use returned the session to the database's pool, application code could not safely iterate over the result sets returned by the methods. Update docs for 'Snapshot.read' and 'Snapshot.execute_sql' to emphasize iteration of their results sets before the session is returned to the database pool (i.e., within the 'with' block which constructs the snapshot). Closesgoogleapis#3769.
landrito pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
…oogleapis#3787) Because the context managers they use returned the session to the database's pool, application code could not safely iterate over the result sets returned by the methods. Update docs for 'Snapshot.read' and 'Snapshot.execute_sql' to emphasize iteration of their results sets before the session is returned to the database pool (i.e., within the 'with' block which constructs the snapshot). Closesgoogleapis#3769.
landrito pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
…oogleapis#3787) Because the context managers they use returned the session to the database's pool, application code could not safely iterate over the result sets returned by the methods. Update docs for 'Snapshot.read' and 'Snapshot.execute_sql' to emphasize iteration of their results sets before the session is returned to the database pool (i.e., within the 'with' block which constructs the snapshot). Closesgoogleapis#3769.
tseaver added a commit
that referenced
this pull request
Sep 13, 2017
dhermes pushed a commit
that referenced
this pull request
Sep 13, 2017
* Fix 'populate_streaming' script after PR #3787. * Add utility for scrubbing orphaned instances. * Suppress instance creation tests by default on CI. Too many orphans, too little quota. * License header, formatting. Addresses: #3951 (comment)#3951 (comment).
parthea pushed a commit
that referenced
this pull request
Mar 9, 2026
…3787) Because the context managers they use returned the session to the database's pool, application code could not safely iterate over the result sets returned by the methods. Update docs for 'Snapshot.read' and 'Snapshot.execute_sql' to emphasize iteration of their results sets before the session is returned to the database pool (i.e., within the 'with' block which constructs the snapshot). Closes#3769.
parthea pushed a commit
that referenced
this pull request
Mar 9, 2026
* Fix 'populate_streaming' script after PR #3787. * Add utility for scrubbing orphaned instances. * Suppress instance creation tests by default on CI. Too many orphans, too little quota. * License header, formatting. Addresses: #3951 (comment)#3951 (comment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the context managers they use returned the session to the database's pool, application code could not safely iterate over the result sets returned by the methods.
Update docs for
Snapshot.readandSnapshot.execute_sqlto emphasize iteration of their results sets before the session is returned to the database pool (i.e., within thewithblock which constructs the snapshot).Closes#3768.