Skip to content

Make the Spanner README better. - #3791

Merged
lukesneeringer merged 2 commits into
googleapis:masterfrom
lukesneeringer:issue-3238
Aug 11, 2017
Merged

Make the Spanner README better.#3791
lukesneeringer merged 2 commits into
googleapis:masterfrom
lukesneeringer:issue-3238

Conversation

@lukesneeringer

@lukesneeringerlukesneeringer commented Aug 11, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

As @vkedia (/cc) pointed out, the existing README is pretty sparse. This improves it.

That said, I have barely used this library and would like to ensure that what I have here is correct and in line with the recommended ways to use the API.

Fixes#3238.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 11, 2017
@lukesneeringerlukesneeringer self-assigned this Aug 11, 2017
@lukesneeringer
lukesneeringer merged commit 6c15d81 into googleapis:masterAug 11, 2017
@lukesneeringer
lukesneeringer deleted the issue-3238 branch August 11, 2017 16:51
vkedia
vkedia reviewed Aug 11, 2017
View reviewed changes
Comment threadspanner/README.rst
# SQL injection attacks.
query = """UPDATE people
SET anniversary = @uxts
WHERE id = @person_id"""

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

vkedia
vkedia reviewed Aug 11, 2017
View reviewed changes
Comment threadspanner/README.rst
See the ``google-cloud-python`` API `Cloud Spanner documentation`_ to learn how
to connect to Cloud Spanner using this Client Library.

.. _Cloud Spanner documentation: https://googlecloudplatform.github.io/google-cloud-python/latest/bigquery/usage.html

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

vkedia
vkedia reviewed Aug 11, 2017
View reviewed changes
Comment threadspanner/README.rst
.. _About Cloud Spanner: https://cloud.google.com/spanner/


Executing Arbitrary SQL in a Transaction

This comment was marked as spam.

Sign in to view

@lukesneeringerlukesneeringer mentioned this pull request Aug 11, 2017
Merged
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@lukesneeringer@landrito
Make the Spanner README better. (googleapis#3791)
3e23b70
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@lukesneeringer@landrito
Make the Spanner README better. (googleapis#3791)
1c026ab
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@lukesneeringer@landrito
Make the Spanner README better. (googleapis#3791)
9eb95b9
@dhermesdhermes mentioned this pull request Aug 24, 2017
Merged
parthea pushed a commit that referenced this pull request Mar 9, 2026
@lukesneeringer
Make the Spanner README better. (#3791)
176e6ac
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tseavertseaverAwaiting requested review from tseaver
2 more reviewers
@vkediavkediavkedia left review comments
@theacodestheacodestheacodes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lukesneeringerlukesneeringer

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lukesneeringer@tseaver@theacodes@vkedia@googlebot