Uh oh!
There was an error while loading. Please reload this page.
Update storage to 1.3.2. - #3814
Merged
Merged
Conversation
Did this to update the lower bound on the `requests` dependency (see googleapis#3736).
theacodes
approved these changes
Aug 15, 2017
theacodes
commented
Aug 15, 2017
Contributor
I see the version bump but not the minimum dep version bump (or am I just missing something)? |
dhermes
commented
Aug 15, 2017
ContributorAuthor
MERP! Good call @jonparrott |
dhermes
commented
Aug 15, 2017
ContributorAuthor
@jonparrott PTAL |
theacodes
approved these changes
Aug 15, 2017
dhermes
commented
Aug 15, 2017
ContributorAuthor
@jonparrott@lukesneeringer The version bump should also be merged into master, so maybe I should re-open #3812 (though I already deleted my branch) |
This was referenced Aug 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did this to update the lower bound on the
requestsdependency (see #3736).This PR is an alternative to #3812. Note the diffbase is
GoogleCloudPlatform:storage-1.3.2, which is at the same point as thestorage-1.3.1branch:https://github.com/GoogleCloudPlatform/google-cloud-python/commits/storage-1.3.1
https://github.com/GoogleCloudPlatform/google-cloud-python/commits/storage-1.3.2