Add google.api.core.retry.Retry decorator by theacodes · Pull Request #3835 · googleapis/google-cloud-python

theacodes · 2017-08-17T18:26:21Z

No description provided.

dhermes

Mostly LGTM (thanks for keeping this PR small)

Sign in to view

-"""Helpers for retrying functions with exponential back-off."""
+"""Helpers for retrying functions with exponential back-off.
+
+The :cls`Retry` decorator can be used to retry function that raise exceptions


Sign in to view

+ predicate (Callable[Exception]): A callable that should return ``True``
+ if the given exception is retryable.
+ initial (float): The minimum about of time to delay. This must
+ be greater than 0.


Sign in to view

+ predicate=if_transient_error,
+ initial=1,
+ maximum=60,
+ multiplier=2,


Sign in to view

+ maximum (float): The maximum about of time to delay.
+ multiplier (float): The multiplier applied to the delay.
+ jitter (float): The maximum about of randomness to apply to the delay.
+ deadline (float): How long to keep retrying.


Sign in to view

+ be greater than 0.
+ maximum (float): The maximum about of time to delay.
+ multiplier (float): The multiplier applied to the delay.
+ jitter (float): The maximum about of randomness to apply to the delay.


Sign in to view

+ """
+ return Retry(
+ predicate=self._predicate,
+ initial=initial if initial is not None else self._initial,


Sign in to view

+ '<Retry predicate={}, initial={:.1f}, maximum={:.1f}, '
+ 'multiplier={:.1f}, jitter={:.1f}, deadline={:.1f}>'.format(
+ self._predicate, self._initial, self._maximum,
+ self._multiplier, self._jitter, self._deadline))


dhermes · 2017-08-17T21:20:33Z

LGTM

Sign in to view

-"""Helpers for retrying functions with exponential back-off."""
+"""Helpers for retrying functions with exponential back-off.
+
+The :cls`Retry` decorator can be used to retry functions that raise exceptions


Sign in to view

 maximum (float): The maximum about of time to delay.
 multiplier (float): The multiplier applied to the delay.
- jitter (float): The maximum about of randomness to apply to the delay.
+ max_jitter (float): The maximum about of randomness to apply to the


Sign in to view

+ return retry_wrapped_func
+
+ def with_deadline(self, deadline):
+ """Returns a copy of this retry with the given deadline.


lukesneeringer

This looks fine. Only putting "comment" since in Hangouts, @jonparrott suggested he does plan on changing the jitter algorithm.

If you end up deciding to leave it, then LGTM. If you end up deciding to change, it I will re-review once you have.

* Add google.api.core.retry.Retry decorator * Add futures dependency * Change jitter algorithm

Add google.api.core.retry.Retry decorator
33ddacd

theacodes added the api: core label Aug 17, 2017

theacodes requested a review from lukesneeringer August 17, 2017 18:26

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 17, 2017

Fix Python 2.7 tests
a26bd48

theacodes mentioned this pull request Aug 17, 2017
Drop tenacity dependency; use google.api.core.retry in google.api.core.future #3837
Merged

dhermes reviewed Aug 17, 2017
View reviewed changes

Address review comments
4ace122

Jon Wayne Parrott added 2 commits August 17, 2017 14:27

Add futures dependency
289d74a

Fix extras
57cfa0d

lukesneeringer reviewed Aug 17, 2017
View reviewed changes

Fix version specifier
7f9249c

lukesneeringer reviewed Aug 17, 2017
View reviewed changes

Comment threadcore/google/api/core/retry.py Outdated
return retry_wrapped_func

def with_deadline(self, deadline):
"""Returns a copy of this retry with the given deadline.
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view

lukesneeringer reviewed Aug 17, 2017
View reviewed changes

Change jitter algorithm, address review comments
820aca4

theacodes merged commit 36304f7 into googleapis:masterAug 17, 2017

theacodes deleted the api-core-retry-decorator branch August 17, 2017 22:34

landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
Add google.api.core.retry.Retry decorator (googleapis#3835)
22ff33d
* Add google.api.core.retry.Retry decorator * Add futures dependency * Change jitter algorithm

landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
Add google.api.core.retry.Retry decorator (googleapis#3835)
1c17aee
* Add google.api.core.retry.Retry decorator * Add futures dependency * Change jitter algorithm

landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
Add google.api.core.retry.Retry decorator (googleapis#3835)
4339f16
* Add google.api.core.retry.Retry decorator * Add futures dependency * Change jitter algorithm

tseaver mentioned this pull request Aug 28, 2017
Cloud spanner client does not seem to be retrying broken streams #3775
Closed

parthea pushed a commit that referenced this pull request Nov 24, 2025
Add google.api.core.retry.Retry decorator (#3835)
71466f8
* Add google.api.core.retry.Retry decorator * Add futures dependency * Change jitter algorithm

Uh oh!

Conversation

theacodes commented Aug 17, 2017

Uh oh!

dhermes left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Aug 17, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

lukesneeringer left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants