Add google.api.core.path_template by theacodes · Pull Request #3851 · googleapis/google-cloud-python

theacodes · 2017-08-22T02:38:46Z

Towards #3842

theacodes · 2017-08-22T02:39:14Z

@lukesneeringer @dhermes this gave me more trouble than I anticipated, but the tests give me confidence that this works as expected.

lukesneeringer · 2017-08-22T02:48:28Z

Still simpler than a lex-yacc implementation. ;-)

Sanity check: Correct?

theacodes · 2017-08-22T02:49:57Z

Much simpler

…

On Mon, Aug 21, 2017, 7:48 PM Luke Sneeringer ***@***.***> wrote: Still simpler than a lex-yacc implementation. ;-) Sanity check: Correct? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3851 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPUc6HWLCb78HkRVkBspwrTMa-n4IIbks5sakF9gaJpZM4O-Cw2> .

Sign in to view

+ raise ValueError(
+ 'Named variable \'{}\' not specified and needed by template '
+ '`{}` at position {}'.format(
+ name, match.string, match.start()))


Sign in to view

+
+ Raises:
+ ValueError: If a positional or named variable is required by the
+ template but not specified.


Sign in to view

+ if not template:
+ return _SINGLE_SEGEMENT_PATTERN.format(name)
+ elif template == '**':
+ return _MULTI_SEGEMENT_PATTERN.format(name)


Sign in to view

+ Returns:
+ bool: True if the path matches.
+ """
+ pattern = _generate_pattern_for_template(tmpl) + '$'


Sign in to view

+
+@pytest.mark.parametrize('tmpl, args, kwargs, exc_match', [
+ # Missing positional arg.
+ ['v1/*', [], {}, 'Positional'],


Sign in to view

+ ['/v1/*/{name}', ['a'], {'name': 'parent'}, '/v1/a/parent'],
+ ['/v1/{name}/*', ['a'], {'name': 'parent'}, '/v1/parent/a'],
+ ['/v1/{parent}/*/{child}/*', ['a', 'b'],
+ {'parent': 'parent', 'child': 'child'}, '/v1/parent/a/child/b'],


Sign in to view

+import six
+
+# Regular expression for extracting variable parts from a path template.
+# The variables can be expressed as:


Sign in to view

+ ['/v1/{name=parent/*}/*', ['a'], {'name': 'parent/child'},
+ '/v1/parent/child/a'],
+ ['/v1/*/{name=parent/**}', ['a'], {'name': 'parent/child/object'},
+ '/v1/a/parent/child/object'],


Sign in to view

+ match (re.Match): A regular expression match.
+
+ Returns:
+ str: The expaned variable to replace the match.


Sign in to view

+import six
+
+# Regular expression for extracting variable parts from a path template.
+# The variables can be expressed as:


Sign in to view

+ is encountered.
+ """
+ replacer = functools.partial(_expand_variable_match, list(args), kwargs)
+ return _VARIABLE_RE.sub(replacer, tmpl)


…GoogleCloudPlatform/python-docs-samples#3851)

Add google.api.core.path_template
e1403e3

theacodes added the api: core label Aug 22, 2017

theacodes requested review from dhermes and lukesneeringer August 22, 2017 02:38

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 22, 2017

Jon Wayne Parrott added 2 commits August 22, 2017 10:15

Clean up some bits
7a1a081

Fix silly typo
f244feb

dhermes reviewed Aug 22, 2017
View reviewed changes

Address review comments
504c3f6

duggelz reviewed Aug 22, 2017
View reviewed changes

Comment threadcore/google/api/core/path_template.py Outdated
match (re.Match): A regular expression match.

Returns:
str: The expaned variable to replace the match.
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view

Fix typo, slight tweak to regexp
b4588ab

duggelz reviewed Aug 22, 2017
View reviewed changes

Fix typo
011b308

lukesneeringer approved these changes Aug 23, 2017
View reviewed changes

theacodes merged commit 357bfeb into googleapis:masterAug 23, 2017

theacodes deleted the api-core-path-template branch August 23, 2017 21:29

parthea pushed a commit that referenced this pull request Jun 4, 2023
chore(deps): update dependency google.cloud.talent to v0.6.1 [(#3851)](…
362f7b7
…GoogleCloudPlatform/python-docs-samples#3851)

parthea pushed a commit that referenced this pull request Nov 24, 2025
Add google.api.core.path_template (#3851)
c4b321f

Uh oh!

Conversation

theacodes commented Aug 22, 2017

Uh oh!

theacodes commented Aug 22, 2017

Uh oh!

lukesneeringer commented Aug 22, 2017

Uh oh!

theacodes commented Aug 22, 2017 via email

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants