Add 'on_error' argument to 'retry.retry_target' and 'Retry'. by tseaver · Pull Request #3891 · googleapis/google-cloud-python

tseaver · 2017-08-28T20:49:51Z

Permit application code to reset / fix-up state before retrying.

Permit application code to reset / fix-up state before retrying. See: #3889

dhermes

LGTM though I think you should let @jonparrott have a look before merging

Sign in to view

 sleep_generator (Iterator[float]): An infinite iterator that determines
 how long to sleep between retries.
 deadline (float): How long to keep retrying the target.
+ on_error(Callable): A function to call while processing a retryable


Sign in to view


 Args:
 func (Callable): The callable to add retry behavior to.
+ on_error(Callable): A function to call while processing a


Sign in to view

+ raise ValueError()
+ return 42
+
+ result = retry.retry_target(


Sign in to view

+
+ result = retry.retry_target(
+ target, predicate, range(10), None, on_error=on_error)
+


theacodes

looks mostly good, just a few questions.

Sign in to view

 raise
 last_exc = exc
+ if on_error is not None:
+ on_error()


Sign in to view

 sleep_generator (Iterator[float]): An infinite iterator that determines
 how long to sleep between retries.
 deadline (float): How long to keep retrying the target.
+ on_error(Callable): A function to call while processing a retryable


Sign in to view

 self._deadline = deadline

- def __call__(self, func):
+ def __call__(self, func, on_error=None):


theacodes · 2017-08-28T22:25:22Z

This is fine to merge once on_error is passed the exc. Then, @tseaver can use it to make #3889 much simpler.

Addresses: #3891 (comment).

Permit application code to reset / fix-up state before retrying.

Add 'on_error' argument to 'retry.retry_target' and 'Retry'.
c14306b
Permit application code to reset / fix-up state before retrying. See: #3889

tseaver added the api: core label Aug 28, 2017

tseaver requested a review from theacodes August 28, 2017 20:49

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 28, 2017

dhermes approved these changes Aug 28, 2017
View reviewed changes

theacodes reviewed Aug 28, 2017
View reviewed changes

Whitespace in new-style docstring specs.
e339f94

theacodes mentioned this pull request Aug 28, 2017
Retry 'UNAVAILABLE' exceptions during streaming #3889
Closed

Pass exception object to 'on_error'.
ddcd917
Addresses: #3891 (comment).

tseaver merged commit 9c4144b into googleapis:masterAug 29, 2017

tseaver deleted the core-retry_target-add-on_error-argument branch August 29, 2017 14:33

tseaver mentioned this pull request Aug 29, 2017
Prep core-0.27.1 release. #3893
Merged

parthea pushed a commit that referenced this pull request Nov 24, 2025
Add 'on_error' argument to 'retry.retry_target' and 'Retry'. (#3891)
9af18ca
Permit application code to reset / fix-up state before retrying.


		result = retry.retry_target(
		target, predicate, range(10), None, on_error=on_error)

Uh oh!

Conversation

tseaver commented Aug 28, 2017

Uh oh!

dhermes left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

theacodes left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

theacodes commented Aug 28, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants