Skip to content

Add 'BucketNotification.delete' API wrapper. - #3983

Merged
tseaver merged 2 commits into
googleapis:3956-storage-notificationsfrom
tseaver:3956-storage-notifications-notification-delete
Sep 16, 2017
Merged

Add 'BucketNotification.delete' API wrapper.#3983
tseaver merged 2 commits into
googleapis:3956-storage-notificationsfrom
tseaver:3956-storage-notifications-notification-delete

Conversation

@tseaver

@tseavertseaver commented Sep 15, 2017

Copy link
Copy Markdown
Contributor

Toward #3956.

@tseavertseaver added api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Sep 15, 2017
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 15, 2017
This was referenced Sep 15, 2017
Closed
Closed
dhermes
dhermes approved these changes Sep 15, 2017
View reviewed changes

@dhermesdhermes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadstorage/google/cloud/storage/notification.py
to the ``client`` stored on the current bucket.

:raises: :class:`google.api.core.exceptions.NotFound`:
if the notification does not exist.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver
tseaver merged commit 0a2a40f into googleapis:3956-storage-notificationsSep 16, 2017
@tseaver
tseaver deleted the 3956-storage-notifications-notification-delete branch September 16, 2017 04:49
@tseavertseaver mentioned this pull request Sep 18, 2017
Merged
tseaver added a commit that referenced this pull request Sep 25, 2017
@tseaver
Add 'BucketNotification.delete' API wrapper. (#3983)
6f3c1e0
Toward #3956.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringerlukesneeringerAwaiting requested review from lukesneeringer
1 more reviewer
@dhermesdhermesdhermes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storageIssues related to the Cloud Storage API.cla: yesThis human has signed the Contributor License Agreement.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tseaver@dhermes@googlebot