Skip to content

Test blob ACL methods w/ 'user_project' set. - #4088

Merged
tseaver merged 1 commit into
googleapis:storage-requester_pays-featurefrom
tseaver:storage-requester_pays-systests-4
Sep 29, 2017
Merged

Test blob ACL methods w/ 'user_project' set.#4088
tseaver merged 1 commit into
googleapis:storage-requester_pays-featurefrom
tseaver:storage-requester_pays-systests-4

Conversation

@tseaver

@tseavertseaver commented Sep 29, 2017

Copy link
Copy Markdown
Contributor

Uses #4086 as a base.

@tseavertseaver added api: storage Issues related to the Cloud Storage API. testing labels Sep 29, 2017
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 29, 2017
@tseaver

Copy link
Copy Markdown
ContributorAuthor

Note that this test does not exercise the IAM features, because I now suspect them to be invalid (see #4087).

@dhermesdhermes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

Comment threadstorage/tests/system.py Outdated
acl.reload()
acl.all().grant_read()
acl.save()
self.assertTrue('READER' in acl.all().get_roles())

This comment was marked as spam.

This comment was marked as spam.

Comment threadstorage/tests/system.py Outdated
new_bucket_name, requester_pays=True)
self.case_buckets_to_delete.append(new_bucket_name)

with_up = Config.CLIENT.bucket(

This comment was marked as spam.

This comment was marked as spam.

@tseaver

Copy link
Copy Markdown
ContributorAuthor

Rebased after merging #4086. I will merge when CI is green.

@tseaver
tseaver merged commit ee54c43 into googleapis:storage-requester_pays-featureSep 29, 2017
@tseaver
tseaver deleted the storage-requester_pays-systests-4 branch September 29, 2017 21:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storageIssues related to the Cloud Storage API.cla: yesThis human has signed the Contributor License Agreement.testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tseaver@dhermes@googlebot