Uh oh!
There was an error while loading. Please reload this page.
Test 'Blob.rewrite' w/ 'user_project' set. - #4093
Merged
tseaver merged 1 commit intoOct 5, 2017
Merged
Conversation
dhermes
approved these changes
Sep 29, 2017
dhermes
left a comment
Contributor
There was a problem hiding this comment.
LGTM, still wish you'd try to factor the try/finally out of these test cases.
| dest = with_user_project.blob('dest', encryption_key=KEY) | ||
| token, rewritten, total = dest.rewrite(source) | ||
| self.assertEqual(token, None) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
tseaver
commented
Sep 29, 2017
ContributorAuthor
@frankyn notes offline:
|
tseaverforce-pushed
the
storage-requester_pays-feature
branch
from
October 2, 2017 22:45
1c67795 to
cd6d50aCompareNote that both new tests are failing when run with the GOOGLE_CLOUD_TESTS_USER_PROJECT variable set, due to a known back-end incompatibility between 'objects.rewrite' and 'userProject' (fix pending review / release).
tseaver added a commit
that referenced
this pull request
Oct 5, 2017
Test 'Blob.rewrite' w/ 'user_project' set.
tseaver added a commit
that referenced
this pull request
Oct 10, 2017
Test 'Blob.rewrite' w/ 'user_project' set.
tseaver added a commit
that referenced
this pull request
Oct 10, 2017
Test 'Blob.rewrite' w/ 'user_project' set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that both new tests are failing.
Because they have to be explicitly enabled (via the `GOOGLE_CLOUD_TESTS_USER_PROJECT`` environment variable, which we aren't yet setting for CI), this PR is OK to merge.