Skip to content

Removing googleapis-common-protos from deps in non-core packages. - #4098

Merged
dhermes merged 3 commits into
googleapis:masterfrom
dhermes:update-grpcio-deps
Oct 4, 2017
Merged

Removing googleapis-common-protos from deps in non-core packages.#4098
dhermes merged 3 commits into
googleapis:masterfrom
dhermes:update-grpcio-deps

Conversation

@dhermes

@dhermesdhermes commented Oct 2, 2017

Copy link
Copy Markdown
Contributor

Also

  • removing grpcio from non-core packages.
  • manually specifying the grpcio dep in core (rather than getting it from googleapis-common-protos[grpc])

(NOTE: This is a followup to #4096.)

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 2, 2017
tseaver
tseaver reviewed Oct 2, 2017
View reviewed changes

@tseavertseaver left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes grpcio an unconditional dependency for all APIs, even storage which is otherwise REST-only. Is that what we want?

@dhermes

dhermes commented Oct 2, 2017

Copy link
Copy Markdown
ContributorAuthor

@tseaver It already was, this is the line being removed from core/setup.py:

'googleapis-common-protos[grpc] >= 1.5.3, < 2.0dev',

@tseaver

tseaver commented Oct 2, 2017

Copy link
Copy Markdown
Contributor

@dhermes Yeah, but literally just now in #4096, right?

@dhermes

dhermes commented Oct 2, 2017

Copy link
Copy Markdown
ContributorAuthor

Ahh good call. That was some extra fail copy-pasta by me in #4096.

@tseaver

tseaver commented Oct 2, 2017

Copy link
Copy Markdown
Contributor

ISTM that adding unconditional dependencies to an already-GA API should be worth some debate.

@dhermes

dhermes commented Oct 2, 2017

Copy link
Copy Markdown
ContributorAuthor

@tseaver Yes I did it by mistake in #4096, will undo here.

@dhermes
Removing googleapis-common-protos from deps in non-core packages.
dde1aba
Also
- removing `grpcio` from non-`core` packages.
- manually specifying the `grpcio` dep in core (rather than getting
it from `googleapis-common-protos[grpc]`)
@dhermes

dhermes commented Oct 3, 2017

Copy link
Copy Markdown
ContributorAuthor

@tseaver PTAL, I made grpc an extra in core.

@jonparrott Does this look like the right approach for packaging?

dhermes
dhermes commented Oct 3, 2017
View reviewed changes
Comment threadvideointelligence/setup.py
install_requires=(
'googleapis-common-protos >= 1.5.3, < 2.0dev',
'google-gax >= 0.15.14, < 0.16dev',
'grpcio >= 1.2.0, < 1.6dev',

This comment was marked as spam.

Sign in to view

tseaver
tseaver approved these changes Oct 4, 2017
View reviewed changes

@tseavertseaver left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The grpc extra (and depending on it from the grpc-only API packages) looks right to me.

@dhermes
dhermes merged commit d3ef455 into googleapis:masterOct 4, 2017
@dhermes
dhermes deleted the update-grpcio-deps branch October 4, 2017 19:45
@dhermes

dhermes commented Oct 4, 2017

Copy link
Copy Markdown
ContributorAuthor

@lukesneeringer Can you follow-up on my question (#4098 (comment)) when you get a chance?

@liyanhui1228liyanhui1228 mentioned this pull request Oct 12, 2017
Merged
@lukesneeringerlukesneeringer mentioned this pull request Oct 13, 2017
Merged
@theacodestheacodes mentioned this pull request Oct 16, 2017
Closed
atulep pushed a commit that referenced this pull request Apr 3, 2023
@dhermes
Removinggoogleapis-common-protosfrom deps in non-corepackages. (…
53f18e6
…#4098)
* Removing `googleapis-common-protos` from deps in non-`core` packages.
Also
- removing `grpcio` from non-`core` packages.
- manually specifying the `grpcio` dep in core (rather than getting
it from `googleapis-common-protos[grpc]`)
* Making `grpc` an extra for `core`.
* Adding `googleapis-common-protos` back to `videointelligence`.
atulep pushed a commit that referenced this pull request Apr 18, 2023
@dhermes
Removinggoogleapis-common-protosfrom deps in non-corepackages. (…
fa5c50b
…#4098)
* Removing `googleapis-common-protos` from deps in non-`core` packages.
Also
- removing `grpcio` from non-`core` packages.
- manually specifying the `grpcio` dep in core (rather than getting
it from `googleapis-common-protos[grpc]`)
* Making `grpc` an extra for `core`.
* Adding `googleapis-common-protos` back to `videointelligence`.
parthea pushed a commit that referenced this pull request Jul 6, 2023
@dhermes
Removinggoogleapis-common-protosfrom deps in non-corepackages. (…
f67d2ff
…#4098)
* Removing `googleapis-common-protos` from deps in non-`core` packages.
Also
- removing `grpcio` from non-`core` packages.
- manually specifying the `grpcio` dep in core (rather than getting
it from `googleapis-common-protos[grpc]`)
* Making `grpc` an extra for `core`.
* Adding `googleapis-common-protos` back to `videointelligence`.
parthea pushed a commit that referenced this pull request Sep 22, 2023
@dhermes
Removinggoogleapis-common-protosfrom deps in non-corepackages. (…
d864ee7
…#4098)
* Removing `googleapis-common-protos` from deps in non-`core` packages.
Also
- removing `grpcio` from non-`core` packages.
- manually specifying the `grpcio` dep in core (rather than getting
it from `googleapis-common-protos[grpc]`)
* Making `grpc` an extra for `core`.
* Adding `googleapis-common-protos` back to `videointelligence`.
parthea pushed a commit that referenced this pull request Oct 21, 2023
@dhermes
Removinggoogleapis-common-protosfrom deps in non-corepackages. (…
cfb9a58
…#4098)
* Removing `googleapis-common-protos` from deps in non-`core` packages.
Also
- removing `grpcio` from non-`core` packages.
- manually specifying the `grpcio` dep in core (rather than getting
it from `googleapis-common-protos[grpc]`)
* Making `grpc` an extra for `core`.
* Adding `googleapis-common-protos` back to `videointelligence`.
parthea pushed a commit that referenced this pull request Oct 22, 2023
@dhermes
Removinggoogleapis-common-protosfrom deps in non-corepackages. (…
ef13273
…#4098)
* Removing `googleapis-common-protos` from deps in non-`core` packages.
Also
- removing `grpcio` from non-`core` packages.
- manually specifying the `grpcio` dep in core (rather than getting
it from `googleapis-common-protos[grpc]`)
* Making `grpc` an extra for `core`.
* Adding `googleapis-common-protos` back to `videointelligence`.
parthea pushed a commit that referenced this pull request Oct 22, 2023
@dhermes
Removinggoogleapis-common-protosfrom deps in non-corepackages. (…
7f848b5
…#4098)
* Removing `googleapis-common-protos` from deps in non-`core` packages.
Also
- removing `grpcio` from non-`core` packages.
- manually specifying the `grpcio` dep in core (rather than getting
it from `googleapis-common-protos[grpc]`)
* Making `grpc` an extra for `core`.
* Adding `googleapis-common-protos` back to `videointelligence`.
parthea pushed a commit that referenced this pull request Nov 24, 2025
@dhermes
Removinggoogleapis-common-protosfrom deps in non-corepackages. (…
b074067
…#4098)
* Removing `googleapis-common-protos` from deps in non-`core` packages.
Also
- removing `grpcio` from non-`core` packages.
- manually specifying the `grpcio` dep in core (rather than getting
it from `googleapis-common-protos[grpc]`)
* Making `grpc` an extra for `core`.
* Adding `googleapis-common-protos` back to `videointelligence`.
parthea pushed a commit that referenced this pull request Nov 24, 2025
@dhermes
Removinggoogleapis-common-protosfrom deps in non-corepackages. (…
5e91aef
…#4098)
* Removing `googleapis-common-protos` from deps in non-`core` packages.
Also
- removing `grpcio` from non-`core` packages.
- manually specifying the `grpcio` dep in core (rather than getting
it from `googleapis-common-protos[grpc]`)
* Making `grpc` an extra for `core`.
* Adding `googleapis-common-protos` back to `videointelligence`.
parthea pushed a commit that referenced this pull request Mar 2, 2026
@dhermes
Removinggoogleapis-common-protosfrom deps in non-corepackages. (…
c93b23e
…#4098)
* Removing `googleapis-common-protos` from deps in non-`core` packages.
Also
- removing `grpcio` from non-`core` packages.
- manually specifying the `grpcio` dep in core (rather than getting
it from `googleapis-common-protos[grpc]`)
* Making `grpc` an extra for `core`.
* Adding `googleapis-common-protos` back to `videointelligence`.
parthea pushed a commit that referenced this pull request Mar 9, 2026
@dhermes
Removinggoogleapis-common-protosfrom deps in non-corepackages. (…
e792e87
…#4098)
* Removing `googleapis-common-protos` from deps in non-`core` packages.
Also
- removing `grpcio` from non-`core` packages.
- manually specifying the `grpcio` dep in core (rather than getting
it from `googleapis-common-protos[grpc]`)
* Making `grpc` an extra for `core`.
* Adding `googleapis-common-protos` back to `videointelligence`.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@tseavertseavertseaver approved these changes
@theacodestheacodestheacodes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lukesneeringerlukesneeringer

@tseavertseaver

Labels

cla: yesThis human has signed the Contributor License Agreement.packaging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dhermes@tseaver@theacodes@lukesneeringer@googlebot