fix api endpoints for storage upload/download by silvolu · Pull Request #414 · googleapis/google-cloud-python

silvolu · 2014-12-11T21:56:14Z

No description provided.

Sign in to view

coveralls · 2014-12-11T22:11:49Z

Changes Unknown when pulling f0395d2 on silvolu:fix-storage-requests-urls into * on GoogleCloudPlatform:master*.

silvolu · 2014-12-12T21:45:47Z

Given that upload/download are currently broken, I'd like to merge this. Any objections?

tseaver · 2014-12-12T23:12:01Z

Nope.

tseaver · 2014-12-12T23:12:42Z

I don't understand why the regression tests were passing on my machine on the branch before the merge, but failing afterward.

fix api endpoints for storage upload/download

silvolu · 2014-12-13T01:37:39Z

Build is broken with oauthclient 1.4.3

dhermes · 2014-12-13T01:40:54Z

Link to broken test?

silvolu · 2014-12-13T01:41:36Z

https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/43892995#L307

dhermes · 2014-12-13T01:43:15Z

Lovely. We fixed broken Py3 support and I'm sure other people are even more broken by this. oauth2clientreally needs some TLC.

silvolu · 2014-12-13T01:48:05Z

I'll pin to 1.3 meanwhile.

silvolu · 2014-12-13T02:04:41Z

Aaaand we're back to green.

dhermes · 2014-12-13T02:54:48Z

Did you file a bug with @craigcitro? I'm unclear on why / where pinning to 1.3.

silvolu · 2014-12-13T03:01:10Z

I didn't, but I'll investigate as soon as I can.

craigcitro · 2014-12-13T03:23:35Z

broken in python 3 only? (on phone)

On Fri, Dec 12, 2014, 7:01 PM Silvano Luciani notifications@github.com
wrote:

I didn't, but I'll investigate as soon as I can.
—
Reply to this email directly or view it on GitHub
#414 (comment)
.

silvolu · 2014-12-13T03:24:59Z

Broken on 2.7. I'm investigating now.

silvolu · 2014-12-13T03:30:41Z

This is the change that's creating the error:
googleapis/oauth2client@3c647bd#diff-d8b1525b7f161cbce2f6438636be9c38L412

silvolu · 2014-12-13T03:46:26Z

Ha! The AttributeError: 'int' object has no attribute 'encode' error is raised when the Content-Length header undergoes cleaning, because its value is an int. This doesn't happen in datastore because the value of the header is explicitly converted to string here, whereas in storage it's not.
I'll fix the storage connection and remove the pinning.

dhermes · 2014-12-13T04:00:56Z

@craigcitrok.encode('ascii') should be changed to something closer to the behavior of str(k) in Python2. This is a bit problematic because six.binary_type(k) fails without an encoding and six.binary_type(k, 'ascii') fails in Python2 (at most one argument).

* chore(python): drop python 3.6 Source-Link: googleapis/synthtool@4f89b13 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c * add api_description to .repo-metadata.json * require python 3.7+ in setup.py * remove python 3.6 sample configs * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * trigger CI Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* fix(deps): Require google-api-core >=1.34.0, >=2.11.0 fix: Drop usage of pkg_resources fix: Fix timeout default values docs(samples): Snippetgen should call await on the operation coroutine before calling result PiperOrigin-RevId: 493260409 Source-Link: googleapis/googleapis@fea4387 Source-Link: googleapis/googleapis-gen@387b734 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzg3YjczNDRjNzUyOWVlNDRiZTg0ZTYxM2IxOWE4MjA1MDhjNjEyYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * add gapic_version.py * add gapic_version.py Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* docs: add streaming detect intent with partial response sample * linting

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

…v3.8.0 (#414)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@f15cc72 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bc5eed3804aec2f05fad42aacf973821d9500c174015341f721a984a0825b6fd

Source-Link: https://togithub.com/googleapis/synthtool/commit/cb960373d12d20f8dc38beee2bf884d49627165e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2d816f26f728ac8b24248741e7d4c461c09764ef9f7be3684d557c9632e46dbd

…414) Source-Link: googleapis/synthtool@95d9289 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c8878270182edaab99f2927969d4f700c3af265accd472c3425deedff2b7fd93 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore(python): drop python 3.6 Source-Link: googleapis/synthtool@4f89b13 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c * add api_description to .repo-metadata.json * require python 3.7+ in setup.py * remove python 3.6 sample configs * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * trigger CI Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* fix: resolve AttributeError in bigquery_storage writer * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * handle AttributeError to avoid race condition * actually catch AttributeError Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Steffany Brown <30247553+steffnay@users.noreply.github.com>

…lates/python_library/.kokoro (#414) Source-Link: googleapis/synthtool@9367caa Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2f155882785883336b4468d5218db737bb1d10c9cea7cb62219ad16fe248c03c Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…ing (#414) The wrapped DB-API uses google-cloud-bigquery-storage to download query results by default. It raises a warning and falls back to the REST API if google-cloud-bigquery-storage is not installed. The google-cloud-bigquery version 3.x library is tested in #401 and it does not include any breaking changes that should affect the SQLAlchemy connector. deps: allow google-cloud-bigquery version 3.x Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery-sqlalchemy/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> 🦕

Closes#414.

refs #414

* deps: update all deps * chore: update tests * chore: run code formatter * chore: ignore warning * chore: make script work on Python 3.8 * chore: install setuptools * test: add tests with mock server * test: add more tests * fix: use base64 encoding for transaction id * fix: create mock server db config * fix: replace double with single quotes

Source-Link: googleapis/synthtool@e44dc0c Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:5ff7446edeaede81c3ed58b23a4e76a5403fba1350ce28478045657303b6479d

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

fix api endpoints for storage upload/download
f0395d2

silvolu reviewed Dec 11, 2014
View reviewed changes

Comment threadgcloud/storage/test_key.py
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view

silvolu added a commit that referenced this pull request Dec 12, 2014
Merge pull request#414from silvolu/fix-storage-requests-urls
ce828ac
fix api endpoints for storage upload/download

silvolu merged commit ce828ac into googleapis:masterDec 12, 2014

tseaver mentioned this pull request Dec 31, 2014
Storage: Support Resumable Uploads #375
Closed

dhermes added the api: storage Issues related to the Cloud Storage API. label Dec 31, 2015

parthea pushed a commit that referenced this pull request Jun 4, 2023
chore(deps): update dependency google-cloud-documentai to v2.3.0 (#414)
c333ea1

parthea pushed a commit that referenced this pull request Jul 6, 2023
chore(main): release 2.8.0 (#414)
ac4b350
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Aug 15, 2023
docs: add streaming detect intent with partial response sample (#414)
ab346d4
* docs: add streaming detect intent with partial response sample * linting

parthea added a commit that referenced this pull request Sep 20, 2023
chore(deps): update dependency google-cloud-bigquery to v3.11.0 (#414)
e310285
Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea pushed a commit that referenced this pull request Sep 22, 2023
chore(deps): update dependency google-cloud-bigquery-datatransfer to …
b5a2af0
…v3.8.0 (#414)

parthea pushed a commit that referenced this pull request Sep 22, 2023
chore(deps): update dependency backoff to v2.0.1 (#414)
1f233a3

parthea pushed a commit that referenced this pull request Sep 22, 2023
chore(main): release 3.8.0 (#414)
641047b
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Sep 22, 2023
chore(deps): update all dependencies (#414)
1a48b75

parthea pushed a commit that referenced this pull request Oct 21, 2023
chore(main): release 3.17.1 (#414)
733e11a
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Nov 24, 2025
tests: allow prerelease deps on Python 3.9 (#415)
2bfb2cf
Closes#414.

parthea pushed a commit that referenced this pull request Nov 24, 2025
build: get kokoro file generation in sync with synthtool (#418)
999ecc7
refs #414

parthea pushed a commit that referenced this pull request Mar 9, 2026
chore(main): release 3.2.3 (#414)
0284d30
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Uh oh!

Conversation

silvolu commented Dec 11, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Dec 11, 2014

Uh oh!

silvolu commented Dec 12, 2014

Uh oh!

tseaver commented Dec 12, 2014

Uh oh!

tseaver commented Dec 12, 2014

Uh oh!

silvolu commented Dec 13, 2014

Uh oh!

dhermes commented Dec 13, 2014

Uh oh!

silvolu commented Dec 13, 2014

Uh oh!

dhermes commented Dec 13, 2014

Uh oh!

silvolu commented Dec 13, 2014

Uh oh!

silvolu commented Dec 13, 2014

Uh oh!

dhermes commented Dec 13, 2014

Uh oh!

silvolu commented Dec 13, 2014

Uh oh!

craigcitro commented Dec 13, 2014

Uh oh!

silvolu commented Dec 13, 2014

Uh oh!

silvolu commented Dec 13, 2014

Uh oh!

silvolu commented Dec 13, 2014

Uh oh!

dhermes commented Dec 13, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants