Skip to content

BQ: remove fetch_data and client references from QueryResults - #4144

Merged
tswast merged 1 commit into
googleapis:bigquery-b2from
tswast:bq-query-results
Oct 10, 2017
Merged

BQ: remove fetch_data and client references from QueryResults#4144
tswast merged 1 commit into
googleapis:bigquery-b2from
tswast:bq-query-results

Conversation

@tswast

@tswasttswast commented Oct 9, 2017

Copy link
Copy Markdown
Contributor

Based on #4143.

Now QueryResults is just a container for the getQueryResults response.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 9, 2017
@tswast
tswast requested review from alixhami, jba and tseaverOctober 9, 2017 21:06
jba
jba reviewed Oct 9, 2017
View reviewed changes
Comment threadbigquery/google/cloud/bigquery/client.py Outdated
if selected_fields is not None:
params['selectedFields'] = [f.name for f in selected_fields]
params['selectedFields'] = ','.join(
[f.name for f in selected_fields])

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

jba
jba approved these changes Oct 9, 2017
View reviewed changes
@tswast
BQ: remove fetch_data and client references from QueryResults
740c89a
Now QueryResults is just a container for the getQueryResults response.
@tswast

tswast commented Oct 10, 2017

Copy link
Copy Markdown
ContributorAuthor

Coverage failure is for list_partitions. I'll double-check the diff to make sure I didn't delete a test.

@tswast
tswast merged commit af98bd4 into googleapis:bigquery-b2Oct 10, 2017
@tswast
tswast deleted the bq-query-results branch October 10, 2017 18:26
tswast added a commit that referenced this pull request Oct 12, 2017
@tswast
BQ: remove fetch_data and client references from QueryResults (#4144)
3f65b7c
Now QueryResults is just a container for the getQueryResults response.
tswast added a commit that referenced this pull request Oct 16, 2017
@tswast
BQ: remove fetch_data and client references from QueryResults (#4144)
868f7c7
Now QueryResults is just a container for the getQueryResults response.
@tswasttswast mentioned this pull request Oct 25, 2017
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringerlukesneeringerAwaiting requested review from lukesneeringer
@tseavertseaverAwaiting requested review from tseaver
@alixhamialixhamiAwaiting requested review from alixhami
1 more reviewer
@jbajbajba approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tswast@jba@googlebot