Skip to content

Set gRPC message options and keepalive. - #4269

Merged
lukesneeringer merged 12 commits into
googleapis:masterfrom
lukesneeringer:custom-channel
Oct 30, 2017
Merged

Set gRPC message options and keepalive.#4269
lukesneeringer merged 12 commits into
googleapis:masterfrom
lukesneeringer:custom-channel

Conversation

@lukesneeringer

@lukesneeringerlukesneeringer commented Oct 26, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes#4083, although the UNAVAILABLE errors still occur sometimes for other reasons.

That will need to be handled with new retry logic, and is being tracked as #4234.

Addendum: Fixes#3886.

@lukesneeringerlukesneeringer self-assigned this Oct 26, 2017
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 26, 2017
@lukesneeringer

lukesneeringer commented Oct 26, 2017

Copy link
Copy Markdown
ContributorAuthor

Ignore the long list of commits that included #4265; squash will fix it. :-)

dhermes
dhermes approved these changes Oct 26, 2017
View reviewed changes

@dhermesdhermes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd love it if you addressed my nits 😀

Comment threadpubsub/google/cloud/pubsub_v1/subscriber/client.py Outdated
target = '{host}:{port}'.format(
host=subscriber_client.SubscriberClient.SERVICE_ADDRESS,
port=subscriber_client.SubscriberClient.DEFAULT_SERVICE_PORT,
)

This comment was marked as spam.

Sign in to view

Comment threadpubsub/google/cloud/pubsub_v1/subscriber/client.py Outdated
'grpc.max_send_message_length': -1,
'grpc.max_receive_message_length': -1,
'grpc.keepalive_time_ms': 30000,
}.items(),

This comment was marked as spam.

Sign in to view

Comment threadpubsub/google/cloud/pubsub_v1/subscriber/client.py Outdated
host=subscriber_client.SubscriberClient.SERVICE_ADDRESS,
port=subscriber_client.SubscriberClient.DEFAULT_SERVICE_PORT,
)
kwargs.setdefault('channel', grpc_helpers.create_channel(

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes
dhermes reviewed Oct 26, 2017
View reviewed changes
Comment threadpubsub/google/cloud/pubsub_v1/subscriber/client.py
import grpc

from google import auth
from google.api_core import grpc_helpers

This comment was marked as spam.

Sign in to view

Comment threadpubsub/google/cloud/pubsub_v1/subscriber/client.py Outdated
host=subscriber_client.SubscriberClient.SERVICE_ADDRESS,
port=subscriber_client.SubscriberClient.DEFAULT_SERVICE_PORT,
)
kwargs.setdefault('channel', grpc_helpers.create_channel(

This comment was marked as spam.

Sign in to view

@lukesneeringer
lukesneeringer merged commit 743ade4 into googleapis:masterOct 30, 2017
@lukesneeringer
lukesneeringer deleted the custom-channel branch October 30, 2017 15:51
dhermes
dhermes reviewed Oct 30, 2017
View reviewed changes
Comment threadpubsub/google/cloud/pubsub_v1/publisher/client.py
self._batches = {}

@property
def target(self):

This comment was marked as spam.

Sign in to view

parthea pushed a commit that referenced this pull request Mar 2, 2026
@lukesneeringer
Set gRPC message options and keepalive. (#4269)
712e9ba
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theacodestheacodesAwaiting requested review from theacodes
1 more reviewer
@dhermesdhermesdhermes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lukesneeringerlukesneeringer

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lukesneeringer@dhermes@googlebot