Skip to content

Pub/Sub autogen refresh - #4297

Closed
lukesneeringer wants to merge 6 commits into
googleapis:masterfrom
lukesneeringer:pubsub-autogen-refresh
Closed

Pub/Sub autogen refresh#4297
lukesneeringer wants to merge 6 commits into
googleapis:masterfrom
lukesneeringer:pubsub-autogen-refresh

Conversation

@lukesneeringer

@lukesneeringerlukesneeringer commented Oct 31, 2017

Copy link
Copy Markdown
Contributor

This is a merger of Pub/Sub with google.api_core. Marked do not merge while Ernest and I work out some khinks.

@lukesneeringerlukesneeringer added api: pubsub Issues related to the Pub/Sub API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Oct 31, 2017
@lukesneeringerlukesneeringer self-assigned this Oct 31, 2017
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 31, 2017
@lukesneeringerlukesneeringer removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 31, 2017
@lukesneeringer

lukesneeringer commented Oct 31, 2017

Copy link
Copy Markdown
ContributorAuthor

This now seems to be in good shape. Lobbing to @jonparrott for review.

@dhermes

dhermes commented Oct 31, 2017

Copy link
Copy Markdown
Contributor

@lukesneeringer FYI #4296 is an uber-release, but I was planning on checking on you before actually pushing the tag for Pub/Sub.

theacodes
theacodes approved these changes Oct 31, 2017
View reviewed changes

@theacodestheacodes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

Comment threadpubsub/google/cloud/pubsub_v1/gapic/publisher_client.py
from google.protobuf import field_mask_pb2

_GAPIC_LIBRARY_VERSION = pkg_resources.get_distribution(
'google-cloud-pubsub', ).version

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadpubsub/google/cloud/pubsub_v1/gapic/publisher_client.py
credentials=credentials,
scopes=self._DEFAULT_SCOPES)

self.iam_policy_stub = (iam_policy_pb2.IAMPolicyStub(channel))

This comment was marked as spam.

Sign in to view

@tseavertseaver added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Nov 6, 2017
@dhermesdhermes mentioned this pull request Nov 22, 2017
Merged
@dhermes

dhermes commented Nov 22, 2017

Copy link
Copy Markdown
Contributor

Closing in favor or #4438 (which literally pushed this exact set of history to start). But that PR is in the GoogleCloudPlatform remote so we can run system tests.

@dhermesdhermes closed this Nov 22, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@theacodestheacodestheacodes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lukesneeringerlukesneeringer

Labels

api: pubsubIssues related to the Pub/Sub API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lukesneeringer@dhermes@theacodes@tseaver@googlebot@landrito