Skip to content

BigTable: Small docs/hygiene tweaks after #4256. - #4333

Merged
dhermes merged 3 commits into
googleapis:masterfrom
dhermes:pr-4256-followup
Nov 3, 2017
Merged

BigTable: Small docs/hygiene tweaks after #4256.#4333
dhermes merged 3 commits into
googleapis:masterfrom
dhermes:pr-4256-followup

Conversation

@dhermes

@dhermesdhermes commented Nov 2, 2017

Copy link
Copy Markdown
Contributor

@dhermesdhermes added api: bigtable Issues related to the Bigtable API. docs labels Nov 2, 2017
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 2, 2017
dhermes
dhermes commented Nov 2, 2017
View reviewed changes
Comment threadbigtable/google/cloud/bigtable/table.py
"""
try:
retry(self.__class__._do_mutate_retryable_rows)(self)
retry(self._do_mutate_retryable_rows)()

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

justinseinlin
justinseinlin reviewed Nov 2, 2017
View reviewed changes
Comment threadbigtable/google/cloud/bigtable/table.py
assert len(retryable_rows) == num_responses
if len(retryable_rows) != num_responses:
raise RuntimeError(
'Unexpected the number of responses', num_responses,

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@chemelnucfinchemelnucfin changed the title Small docs/hygiene tweaks after #4256.Bigtable: Small docs/hygiene tweaks after #4256.Nov 3, 2017
@chemelnucfinchemelnucfin changed the title Bigtable: Small docs/hygiene tweaks after #4256.BigTable: Small docs/hygiene tweaks after #4256.Nov 3, 2017
@dhermes

dhermes commented Nov 3, 2017

Copy link
Copy Markdown
ContributorAuthor

Merging with an LGTM from @tseaver in chat.

@dhermes
dhermes merged commit e12372d into googleapis:masterNov 3, 2017
@dhermes
dhermes deleted the pr-4256-followup branch November 3, 2017 16:29
@justinseinlinjustinseinlin mentioned this pull request Nov 3, 2017
Merged
parthea pushed a commit that referenced this pull request Nov 22, 2025
@dhermes
BigTable: Small docs/hygiene tweaks after#4256. (#4333)
e8ffd16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringerlukesneeringerAwaiting requested review from lukesneeringer
1 more reviewer
@justinseinlinjustinseinlinjustinseinlin left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@lukesneeringerlukesneeringer

@tseavertseaver

Labels

api: bigtableIssues related to the Bigtable API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dhermes@justinseinlin@lukesneeringer@tseaver@googlebot