Skip to content

api_core: Add routing header - #4336

Merged
theacodes merged 5 commits into
googleapis:masterfrom
evaogbe:api_core-routing-header
Nov 8, 2017
Merged

api_core: Add routing header#4336
theacodes merged 5 commits into
googleapis:masterfrom
evaogbe:api_core-routing-header

Conversation

@evaogbe

@evaogbeevaogbe commented Nov 3, 2017

Copy link
Copy Markdown
Contributor

Example:

routing_header=google.api_core.gapic_v1.routing_header(
[('name', name), ('book.read', book.read)])
self._create_book(request, retry=retry, timeout=timeout, metadata=[routing_header])

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 3, 2017
@evaogbeevaogbe mentioned this pull request Nov 3, 2017
Merged
theacodes
theacodes suggested changes Nov 3, 2017
View reviewed changes
Comment threadapi_core/google/api_core/gapic_v1/routing_header.py Outdated

"""Helpers for handling routing header params."""

METADATA_KEY = 'x-goog-header-params'

This comment was marked as spam.

Sign in to view

Comment threadapi_core/google/api_core/gapic_v1/routing_header.py Outdated

def to_routing_header(params):
"""Returns the routing header string that the params form"""
return "&".join(["{}={}".format(*pair) for pair in params])

This comment was marked as spam.

Sign in to view

Comment threadapi_core/tests/unit/gapic/test_routing_header.py Outdated
params = [('name', 'meep'), ('book.read', True)]
metadata = routing_header.to_grpc_metadata(params)
assert metadata == (
routing_header.METADATA_KEY, "name=meep&book.read=True")

This comment was marked as spam.

Sign in to view

theacodes
theacodes suggested changes Nov 3, 2017
View reviewed changes
Comment threadapi_core/google/api_core/gapic_v1/routing_header.py Outdated
"""Helpers for handling routing header params."""


try:

This comment was marked as spam.

Sign in to view

Comment threadapi_core/google/api_core/gapic_v1/routing_header.py Outdated
ROUTING_METADATA_KEY = 'x-goog-header-params'


def _to_url_string(x):

This comment was marked as spam.

Sign in to view

theacodes
theacodes reviewed Nov 6, 2017
View reviewed changes
Comment threadapi_core/google/api_core/gapic_v1/routing_header.py

def to_routing_header(params):
"""Returns the routing header string that the params form"""
return urlencode(params)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@theacodes
theacodes merged commit 10ef028 into googleapis:masterNov 8, 2017
This was referenced Dec 8, 2017
Merged
Merged
parthea pushed a commit that referenced this pull request Nov 24, 2025
@evaogbeJon Wayne Parrott
api_core: Add routing header (#4336)
ca4ab50
* api_core: Add routing header
* Fix linting
* Review fixes
* More review fixes
* Documentation fixes
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringerlukesneeringerAwaiting requested review from lukesneeringer
1 more reviewer
@theacodestheacodestheacodes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: corecla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@evaogbe@theacodes@googlebot