Allow specifying read consistency by chemelnucfin · Pull Request #4343 · googleapis/google-cloud-python

chemelnucfin · 2017-11-03T23:29:15Z

lukesneeringer

This looks sane to me. Please get either@tseaver or @dhermes to also say yes before merging.

chemelnucfin · 2017-11-06T14:33:45Z

Ok.

On Mon, Nov 6, 2017, 6:21 AM Luke Sneeringer ***@***.***> wrote: ***@***.**** approved this pull request. This looks sane to me. Please get *either* @tseaver <https://github.com/tseaver> or @dhermes <https://github.com/dhermes> to also say yes before merging. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4343 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADzDDExUi_PSKcCKImv96T9FRvw-5GIDks5szxX0gaJpZM4QRyrZ> .

tseaver · 2017-11-06T15:09:32Z

@chemelnucfin Please put the "Closes #4340" in the description, not the title. E.g., for a single-commit PR:

$ git commit datastore/ -m "Specify read consistency.Closes #4340."

tseaver · 2017-11-06T15:10:33Z

Also, please add labels when you create the PR.

tseaver

The tests for get_read_options need to move from test_client.py to test_helpers.py.

Sign in to view

- _determine_default_project as _base_default_project)
+from google.cloud._helpers import (_determine_default_project as
+ _default_project)
+


Sign in to view

 from google.cloud.datastore.key import Key
 from google.cloud.datastore.query import Query
 from google.cloud.datastore.transaction import Transaction
+


Sign in to view


 if project is None:
- project = _base_default_project(project=project)
+ project = _default_project(project=project)


Sign in to view


+ :type eventual: bool
+ :param eventual: (Optional) Defaults to strongly consistent (False).
+ Setting True will use eventual consistency,


Sign in to view

 datastore_api=self._datastore_api,
 project=self.project,
- key_pbs=[k.to_protobuf() for k in keys],
+ key_pbs=[key.to_protobuf() for key in keys],


Sign in to view

 from google.cloud.datastore.entity import Entity
 from google.cloud.datastore.key import Key
+from google.cloud.proto.datastore.v1 import entity_pb2 as _entity_pb2
+from google.cloud.proto.datastore.v1 import datastore_pb2 as _datastore_pb2


googlebot · 2017-11-06T18:28:55Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

tseaver · 2017-11-06T18:34:53Z

@chemelnucfin Rather than merging master into your branch (which is what confused the @goolebot) we prefer to rebase the branch against master, which keeps the PR focused on just the relevant changes.

chemelnucfin · 2017-11-06T20:09:46Z

Sorry about that. I think I rebased on the wrong branch. I think that's better now.

chemelnucfin · 2017-11-08T04:37:25Z

@dhermes @tseaver Is this ok?

Sign in to view

-from google.cloud._helpers import (
-_determine_default_project as _base_default_project)
+from google.cloud._helpers import (_determine_default_project as
+ _base_default_project)


Sign in to view

 from google.cloud.datastore.key import Key

+from google.protobuf import struct_pb2
+from google.type import latlng_pb2


…Platform/python-docs-samples#4350) fixes#4343

* Closes#4340 - Specify Read Consistency * review changes * merge conflicts; correct imports

chemelnucfin requested a review from lukesneeringer as a code owner November 3, 2017 23:29

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 3, 2017

chemelnucfin changed the title ~~Closes #4340 - Specify Read Consistency~~Datastore: Closes #4340 - Specify Read ConsistencyNov 3, 2017

chemelnucfin force-pushed the issue4340-readconsistency branch 2 times, most recently from a79426d to b1258feCompare November 4, 2017 18:01

lukesneeringer approved these changes Nov 6, 2017
View reviewed changes

tseaver changed the title ~~Datastore: Closes #4340 - Specify Read Consistency~~Datastore: Specify Read ConsistencyNov 6, 2017

tseaver changed the title ~~Datastore: Specify Read Consistency~~Allow specifying read consistencyNov 6, 2017

tseaver suggested changes Nov 6, 2017
View reviewed changes

dhermes reviewed Nov 6, 2017
View reviewed changes

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 6, 2017

chemelnucfin force-pushed the issue4340-readconsistency branch from 0d45147 to 9605172Compare November 6, 2017 20:08

chemelnucfin added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 8, 2017

tseaver approved these changes Nov 8, 2017
View reviewed changes

chemelnucfin added 3 commits November 8, 2017 20:49

Closesgoogleapis#4340- Specify Read Consistency
bfbc2d1

review changes
3015e29

merge conflicts; correct imports
d09d907

chemelnucfin force-pushed the issue4340-readconsistency branch from 664e5cc to d09d907Compare November 9, 2017 05:40

chemelnucfin merged commit 4941cbf into googleapis:masterNov 9, 2017

dhermes reviewed Nov 9, 2017
View reviewed changes

Comment threaddatastore/google/cloud/datastore/client.py
from google.cloud._helpers import (
_determine_default_project as _base_default_project)
from google.cloud._helpers import (_determine_default_project as
_base_default_project)
This comment was marked as spam.
Sign in to view

dhermes reviewed Nov 9, 2017
View reviewed changes

Comment threaddatastore/google/cloud/datastore/helpers.py
from google.cloud.datastore.key import Key

from google.protobuf import struct_pb2
from google.type import latlng_pb2
This comment was marked as spam.
Sign in to view

chemelnucfin added a commit to chemelnucfin/google-cloud-python that referenced this pull request Nov 9, 2017
cosmetic changes to addressgoogleapis#4343
7ff8510

chemelnucfin added a commit to chemelnucfin/google-cloud-python that referenced this pull request Nov 9, 2017
cosmetic changes to addressgoogleapis#4343
5c979e9

chemelnucfin mentioned this pull request Nov 9, 2017
cosmetic changes to address #4343 #4376
Merged

chemelnucfin added a commit that referenced this pull request Nov 9, 2017
cosmetic changes to address#4343(#4376)
85b190e

parthea pushed a commit that referenced this pull request Oct 21, 2023
testing(automl): retry upon InternalServerError [(#4350)](GoogleCloud…
4b8e11b
…Platform/python-docs-samples#4350) fixes#4343

parthea pushed a commit that referenced this pull request Nov 24, 2025
Allow specifying read consistency (#4343)
98302b6
* Closes#4340 - Specify Read Consistency * review changes * merge conflicts; correct imports

parthea pushed a commit that referenced this pull request Nov 24, 2025
cosmetic changes to address#4343(#4376)
f53f740

Uh oh!

Conversation

chemelnucfin commented Nov 3, 2017• edited by tseaver Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lukesneeringer left a comment

Choose a reason for hiding this comment

Uh oh!

chemelnucfin commented Nov 6, 2017 via email

Uh oh!

tseaver commented Nov 6, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tseaver commented Nov 6, 2017

Uh oh!

tseaver left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

googlebot commented Nov 6, 2017

Uh oh!

tseaver commented Nov 6, 2017

Uh oh!

chemelnucfin commented Nov 6, 2017

Uh oh!

chemelnucfin commented Nov 8, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

chemelnucfin commented Nov 3, 2017•
edited by tseaver
Loading

tseaver commented Nov 6, 2017•
edited
Loading