Uh oh!
There was an error while loading. Please reload this page.
Auto-generate Trace v2 - #4379
Merged
Merged
Conversation
dhermes
commented
Nov 9, 2017
Contributor
Anything in particular you'd like reviewed? |
liyanhui1228
commented
Nov 9, 2017
Contributor
Thanks for generating this! Why removing the V1 related code? We probably need to keep both V1 and V2 library as the V1 API is still serving. |
lukesneeringer
commented
Nov 10, 2017
ContributorAuthor
Whups, sorry about that. Re-added the v1 guts. Note that users explicitly wanting to use v1 will have to |
| from google.api import annotations_pb2 as google_dot_api_dot_annotations__pb2 | ||
| from google.devtools.cloudtrace_v2.proto import trace_pb2 as google_dot_devtools_dot_cloudtrace__v2_dot_proto_dot_trace__pb2 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
2 tasks
liyanhui1228
approved these changes
Nov 20, 2017
liyanhui1228
commented
Nov 20, 2017
Contributor
CircleCI is blocked by error-reporting system tests. Verified locally that the trace tests passed. LGTM to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.