Skip to content

Move datetime helpers from google.cloud._helpers to google.api_core.datetime_helpers - #4399

Merged
theacodes merged 4 commits into
googleapis:masterfrom
theacodes:api-core-datetime-helpers-from-cloud-core
Nov 16, 2017
Merged

Move datetime helpers from google.cloud._helpers to google.api_core.datetime_helpers#4399
theacodes merged 4 commits into
googleapis:masterfrom
theacodes:api-core-datetime-helpers-from-cloud-core

Conversation

@theacodes

Copy link
Copy Markdown
Contributor

Towards #4267

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 15, 2017

@dhermesdhermes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theacodes

Copy link
Copy Markdown
ContributorAuthor

After chatting with @dhermes, we determined that while we could technically remove all of the if pytz statements from cloud core, it's best to just not modify that library. So instead I'm going to just pragma: NO COVER those lines as a lesser of several evils scenario.

@dhermes

Copy link
Copy Markdown
Contributor

Still LGTM, but let's wait for green?

@theacodes

Copy link
Copy Markdown
ContributorAuthor

Ya

@theacodes
theacodes merged commit 39e4cd4 into googleapis:masterNov 16, 2017
@theacodes
theacodes deleted the api-core-datetime-helpers-from-cloud-core branch November 16, 2017 22:37
parthea pushed a commit that referenced this pull request Nov 24, 2025
…atetime_helpers (#4399)
* Move datetime helpers from google.cloud._helpers to google.api_core.datetime_helpers
* Add pragma statements
* Move them around
* Fix test coverage
parthea pushed a commit that referenced this pull request Nov 24, 2025
…atetime_helpers (#4399)
* Move datetime helpers from google.cloud._helpers to google.api_core.datetime_helpers
* Add pragma statements
* Move them around
* Fix test coverage
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: corecla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@theacodes@dhermes@googlebot