BigQuery: docs for Row.keys, items, values, and get functions. by tswast · Pull Request #4410 · googleapis/google-cloud-python

tswast · 2017-11-17T17:12:25Z

I forgot to ask for these in #4393 before I merged.

Sign in to view


 def values(self):
+ """Return the values included in this row.
+


Sign in to view

+ ['x', 'y']
 """
 keys = self._xxx_field_to_index.keys()
 return keys


Sign in to view

@@ -808,18 +824,38 @@ def items(self):
 return items


Sign in to view

- >>> Row(('a', 'b'), {'x': 0, 'y': 1}).get('z', default = '')
- ''
+ """Return value for ``key`` if ``key`` is in the row, else
+ ``default``.


Sign in to view

+
+ Args:
+ key (str): The key of the column to access
+


Sign in to view

+ >>> Row(('a', 'b'), {'x': 0, 'y': 1}).get('x')
+ 'a'
+
+ The default value is ``None`` when the key does not exist.


- Refactors items, keys to return iterators. - Copies values to prevent mutating the original row object.

dhermes · 2017-11-17T18:05:04Z

@tswast For future PRs, can you squash while merging the PR? It's harder to review a PR when I can't tell what you changed when squashing. (Though I definitely feel the seem way, I squash locally a lot because for some reason I care about commit log clutter, even though we are 5500+ commits in to this project.)

Sign in to view

- Return keys as of a dict:
- >>> Row(('a', 'b'), {'x': 0, 'y': 1}).keys()
- ['x', 'y']
+ return copy.deepcopy(self._xxx_values)


Sign in to view

- ]
- return items
+ for key, index in six.iteritems(self._xxx_field_to_index):
+ yield (key, copy.deepcopy(self._xxx_values[index]))


dhermes

LGTM, though I'm a bit "sad" about the copies. (They seem necessary evils, but still evils.)

tswast · 2017-11-17T18:30:42Z

Yeah, it is a bit sad about copies. There's definitely a trade-off between safety and performance. Probably better to err on the side of safety.

dhermes · 2017-11-17T19:08:32Z

@tswast Looks like the generators broke the build: https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/4288

Shall we revert, then re-submit this PR but push the branch to the GoogleCloudPlatform remote so system tests run?

tswast · 2017-11-17T19:15:44Z

Yeah, let's revert. I didn't think to check the system tests.

#4410)" This reverts commit f3e745e.

#4410)" (#4412) This reverts commit f3e745e.

tswast requested a review from lukesneeringer as a code owner November 17, 2017 17:12

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 17, 2017

tswast requested review from dhermes and tseaver November 17, 2017 17:12

tswast added the api: bigquery Issues related to the BigQuery API. label Nov 17, 2017

dhermes reviewed Nov 17, 2017
View reviewed changes

tswast force-pushed the bq-row-docs branch from 96f3c78 to fb48263Compare November 17, 2017 17:29

BigQuery: docs for Row.keys, items, values, and get functions.
8bc2f4e
- Refactors items, keys to return iterators. - Copies values to prevent mutating the original row object.

tswast force-pushed the bq-row-docs branch from fb48263 to 8bc2f4eCompare November 17, 2017 17:59

dhermes reviewed Nov 17, 2017
View reviewed changes

BQ: change Row.values() into a generator
d069e4b

dhermes approved these changes Nov 17, 2017
View reviewed changes

tswast merged commit f3e745e into googleapis:masterNov 17, 2017

tswast deleted the bq-row-docs branch November 17, 2017 18:37

tswast added a commit that referenced this pull request Nov 17, 2017
Revert "BigQuery: docs for Row.keys, items, values, and get functions. (
cd2f376
#4410)" This reverts commit f3e745e.

tswast mentioned this pull request Nov 17, 2017
Revert "BigQuery: docs for Row.keys, items, values, and get functions." #4412
Merged

tswast added a commit that referenced this pull request Nov 17, 2017
Revert "BigQuery: docs for Row.keys, items, values, and get functions. (
ce96e85
#4410)" (#4412) This reverts commit f3e745e.

tswast mentioned this pull request Nov 17, 2017
BigQuery: docs for Row.keys, items, values, and get functions. #4413
Merged

Uh oh!

Conversation

tswast commented Nov 17, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Nov 17, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes left a comment

Choose a reason for hiding this comment

Uh oh!

tswast commented Nov 17, 2017

Uh oh!

dhermes commented Nov 17, 2017

Uh oh!

tswast commented Nov 17, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants