Spanner: Prevents Conflict from having the same database name

[chemelnucfin]

Somehow this conflict occurs occasionally. I might have created another temp_db database while working on the tests.

This PR guards against it.

[chemelnucfin]

You are right, I wasn't thinking about race conditions, since it was just a test, but only locally where I was reusing the same name. Should just close this issue or try to deal with the race conditions? Thanks.

…

On Sat, Nov 18, 2017, 1:45 PM Danny Hermes ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In spanner/tests/system/test_system.py <#4417 (comment)> : > @@ -845,12 +845,11 @@ def test_read_w_index(self): temp_db = Config.INSTANCE.database( 'test_read_w_index', ddl_statements=DDL_STATEMENTS + EXTRA_DDL, pool=pool) - operation = temp_db.create() + if not temp_db.exists(): @chemelnucfin <https://github.com/chemelnucfin> This won't help contention, because if it exists, then (at least) two tests would be trying to modify the same database. You'd be better of just failing the test if temp_db.exists(). (Even this is not quite sufficient due to race conditions.) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4417 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADzDDB_eZB-F1a6dKHs4xlFPIuTcAVG3ks5s30_kgaJpZM4QjALB> .

[chemelnucfin]

Closing in favor of #4435