Skip to content

BigTable: try resetting BIGTABLE_EMULATOR_HOST to fix bigtable test errors - #4443

Closed
igorbernstein2 wants to merge 1 commit into
googleapis:pr-3811from
igorbernstein2:debug-bigtable-test
Closed

BigTable: try resetting BIGTABLE_EMULATOR_HOST to fix bigtable test errors#4443
igorbernstein2 wants to merge 1 commit into
googleapis:pr-3811from
igorbernstein2:debug-bigtable-test

Conversation

@igorbernstein2

Copy link
Copy Markdown
Contributor

No description provided.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 22, 2017
@igorbernstein2

Copy link
Copy Markdown
ContributorAuthor

I couldn't reproduce the test failures locally, so I'm not sure if this is the actual cause of the issues.

@dhermesdhermes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igorbernstein2 Instead, can you use

@mock.patch('os.environ', new={})deftest_retry(self):
...

This way, any changes you make to os.environ in this method will be isolated.

Also, as far as reproducing, you can use the same Docker image our tests run in:

docker run \
--rm \
--tty \
--interactive \
--volume $(git rev-parse --show-toplevel):/var/code/gcp/ \
googleapis/nox:0.17.0 \
/bin/bash

(This won't help you decode the credentials file, but I'm happy to chat about how you might get one of those if you're not familiar.)

@chemelnucfinchemelnucfin added the api: bigtable Issues related to the Bigtable API. label Nov 23, 2017
@chemelnucfinchemelnucfin changed the title try resetting BIGTABLE_EMULATOR_HOST to fix bigtable test errorsBigTable: try resetting BIGTABLE_EMULATOR_HOST to fix bigtable test errorsNov 23, 2017
@dhermes
dhermes changed the base branch from master to pr-3811December 4, 2017 18:43
@dhermes

Copy link
Copy Markdown
Contributor

@igorbernstein2 Since #3811 will be (temporarily) reverted, I have changed the base of this PR from master to pr-3811 (a branch in the main remote that has the changes from #3811 still)

@chemelnucfinchemelnucfin added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 15, 2018
@tseavertseaver removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Feb 20, 2018
@theacodes

Copy link
Copy Markdown
Contributor

I'm closing this for now. It's been open since last year and no movement, and as far as I know our bigtable tests are passing.

Feel free to comment if this is still relevant.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtableIssues related to the Bigtable API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@igorbernstein2@dhermes@theacodes@tseaver@chemelnucfin@googlebot