Skip to content

WIP: Spanner: Bad constructor behavior - #4502

Closed
chemelnucfin wants to merge 1 commit into
googleapis:masterfrom
chemelnucfin:spanner_ctor_bad
Closed

WIP: Spanner: Bad constructor behavior#4502
chemelnucfin wants to merge 1 commit into
googleapis:masterfrom
chemelnucfin:spanner_ctor_bad

Conversation

@chemelnucfin

@chemelnucfinchemelnucfin commented Nov 30, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

According to the documents, https://cloud.google.com/spanner/docs/reference/rest/v1/KeySet,
these should be errors. This came up when I was looking at partial ranges.
The to_pb method does not work if the keys aren't specified.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 30, 2017
@chemelnucfinchemelnucfin changed the title Spanner: ctor bad behaviorSpanner: Constructor bad behaviorNov 30, 2017
@chemelnucfinchemelnucfin added api: spanner Issues related to the Spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Nov 30, 2017
@chemelnucfinchemelnucfin changed the title Spanner: Constructor bad behaviorSpanner: Bad constructor behaviorNov 30, 2017
@chemelnucfin
chemelnucfinforce-pushed the spanner_ctor_bad branch 2 times, most recently from aa9582e to 008e5b0CompareNovember 30, 2017 07:45
@chemelnucfin

chemelnucfin commented Nov 30, 2017•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Something is wrong with this range stuff, I just haven't figured out how to fix it yet.

@chemelnucfinchemelnucfin changed the title Spanner: Bad constructor behaviorWIP: Spanner: Bad constructor behaviorNov 30, 2017
@chemelnucfin

chemelnucfin commented Dec 4, 2017

Copy link
Copy Markdown
ContributorAuthor

See #4515

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringerlukesneeringerAwaiting requested review from lukesneeringer

Assignees

No one assigned

Labels

api: spannerIssues related to the Spanner API.cla: yesThis human has signed the Contributor License Agreement.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chemelnucfin@googlebot