Uh oh!
There was an error while loading. Please reload this page.
Spanner: clean up databases after use - #4556
Conversation
tseaver
commented
Dec 20, 2017
This change is not correct. We are forced to re-use / share instances across test runs (and for other purposes), which means that we should only ever drop databases which are created in the current test run. |
But the way the tests are set up, it doesn't seem like all the tests get cleaned up, especially if I interrupt in the middle? |
dhermes
commented
Dec 20, 2017
Our cleanup has been tailored to a "graceful" exit (i.e. tests may error, but user doesn't kill process). We could consider a more resilient approach but I don't think it's worth the effort. |
tseaver
commented
Dec 20, 2017
Until we go back to using a created-from-scratch instance, we cannot drop all databases, because the CI may be running more than one job at once in the same instance. There may also be other databases pre-populated (e.g., to run the "large chunk" tests) which should never be dropped. |
…loudPlatform/python-docs-samples#4556) Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
No description provided.