Skip to content

Spanner: Range read with single key - #4572

Merged
chemelnucfin merged 1 commit into
googleapis:masterfrom
chemelnucfin:spanner_range_single_key
Dec 18, 2017
Merged

Spanner: Range read with single key#4572
chemelnucfin merged 1 commit into
googleapis:masterfrom
chemelnucfin:spanner_range_single_key

Conversation

@chemelnucfin

@chemelnucfinchemelnucfin commented Dec 11, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 11, 2017
dhermes
dhermes reviewed Dec 11, 2017
View reviewed changes
Comment threadspanner/tests/system/test_system.py Outdated
snapshot = session.snapshot(read_timestamp=committed, multi_use=True)
all_data_rows = list(self._row_data(ROW_COUNT))

single_key = KeyRange(start_closed=[START], end_open=[START+1])

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@chemelnucfin
chemelnucfinforce-pushed the spanner_range_single_key branch from 2267fb6 to 6671ac2CompareDecember 11, 2017 21:24
dhermes
dhermes approved these changes Dec 18, 2017
View reviewed changes

@dhermesdhermes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than my nit.

It seems you might want to put the newly added case in a separate method on the unittest.TestCase subclass, but it sort of belongs where you put it, so I don't feel strongly.

Comment threadspanner/tests/system/test_system.py
rows = list(snapshot.read(
self.TABLE, self.COLUMNS, keyset))
expected = all_data_rows[START:END+1]
expected = all_data_rows[START : END+1]

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@chemelnucfin
chemelnucfin merged commit 509ac16 into googleapis:masterDec 18, 2017
@chemelnucfinchemelnucfin mentioned this pull request Dec 18, 2017
Merged
parthea pushed a commit that referenced this pull request Mar 9, 2026
@chemelnucfin
Spanner: Range read with single key (#4572)
978f0e7
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringerlukesneeringerAwaiting requested review from lukesneeringer
1 more reviewer
@dhermesdhermesdhermes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chemelnucfin@dhermes@googlebot