Skip to content

Spanner: More keyset tests - #4623

Closed
chemelnucfin wants to merge 1 commit into
googleapis:masterfrom
chemelnucfin:spanner_double_keys
Closed

Spanner: More keyset tests#4623
chemelnucfin wants to merge 1 commit into
googleapis:masterfrom
chemelnucfin:spanner_double_keys

Conversation

@chemelnucfin

@chemelnucfinchemelnucfin commented Dec 19, 2017

Copy link
Copy Markdown
Contributor

breaking up #4515

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 19, 2017
@chemelnucfinchemelnucfin mentioned this pull request Dec 19, 2017
Closed
dhermes
dhermes reviewed Dec 19, 2017
View reviewed changes
Comment threadspanner/tests/unit/test_keyset.py
def _make_one(self, *args, **kwargs):
return self._getTargetClass()(*args, **kwargs)

def _check_unused_keys(self, krange, used_keys):

This comment was marked as spam.

Sign in to view

Comment threadspanner/tests/unit/test_keyset.py
self.assertEqual(len(krange_pb.end_closed), 1)
self.assertEqual(krange_pb.end_closed.values[0].string_value, KEY_2[0])

def test_ctor_empty_list_start_closed_and_key_end_closed(self):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermesdhermes mentioned this pull request Dec 19, 2017
Merged
@chemelnucfinchemelnucfin added the api: spanner Issues related to the Spanner API. label Dec 20, 2017
@chemelnucfin

chemelnucfin commented Dec 20, 2017

Copy link
Copy Markdown
ContributorAuthor

Going to close this for now. I might add the tests back in later if necessary.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringerlukesneeringerAwaiting requested review from lukesneeringer
1 more reviewer
@dhermesdhermesdhermes left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spannerIssues related to the Spanner API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chemelnucfin@dhermes@googlebot