Release Spanner v0.30.0 by theacodes · Pull Request #4732 · googleapis/google-cloud-python

theacodes · 2018-01-10T22:57:32Z

No description provided.

theacodes · 2018-01-10T22:57:46Z

Must be rebased on #4730 before merging.

dhermes

LGTM mostly

Sign in to view

+
+### Implementation Changes
+
+- The underlying autogenerated client library was re-generated to pick up new features and resolve bugs. (#4695)


Sign in to view

+
+- The underlying autogenerated client library was re-generated to pick up new features and resolve bugs. (#4695)
+- Made sure **exactly** one of `start_*`/`end_*` are passed to KeyRange. (#4618)
+- Made `row`, `consume_all`, and `consume_next` private (#4492)


Sign in to view

+
+- Brought Spanner README more in line with others. (#4306, #4317)
+
+### Testing


tseaver · 2018-01-10T23:07:16Z

I still believe that the validation change in the KeyRange constructor in #4618 was ill-advised (see #4694). If we leave it in place for this release, it should be highlighted as a breaking change.

dhermes · 2018-01-10T23:09:07Z

@tseaver I was going to mention that in my review, thanks for pointing it out.

tseaver · 2018-01-10T23:11:56Z

#4492 is a breaking change, as well: it removed the rows property and the consume_all method, making consume_next private.

theacodes · 2018-01-10T23:43:32Z

Reverting it. We can revisit it at a later time if needed.

theacodes · 2018-01-11T00:57:52Z

Rebased and good to merge when CI is green and api_core 0.1.4 is released (#4730)

chemelnucfin · 2018-01-11T01:00:37Z

@jonparrott That change was suggested by @vkedia

theacodes · 2018-01-11T01:01:53Z

@chemelnucfin two different breaking changes were discussed, which were you referring to? The change of making a few members private was not reverted and I'm totally cool with it.

chemelnucfin · 2018-01-11T01:12:54Z

The few member private ones. _row and _consume_next. sorry for not being clear. Trying to deal with the spanner keys issue right now.

…

On Wed, Jan 10, 2018 at 5:01 PM, Jon Wayne Parrott ***@***.*** > wrote: @chemelnucfin <https://github.com/chemelnucfin> two different breaking changes were discussed, which were you referring to? The change of making a few member private was *not* reverted and I'm totally cool with it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4732 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADzDDKEquhaGj577OYd_-Hwip9jx8dx5ks5tJV2EgaJpZM4RaEjd> .

theacodes · 2018-01-11T17:26:38Z

#4735 is now included, thanks, @chemelnucfin.

Waiting for CI and then merging. :)

theacodes added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 10, 2018

theacodes requested review from dhermes and lukesneeringer January 10, 2018 22:57

theacodes requested a review from tseaver as a code owner January 10, 2018 22:57

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 10, 2018

dhermes approved these changes Jan 10, 2018
View reviewed changes

theacodes force-pushed the release-spanner-v0.30.0 branch from 680c451 to 4efea87Compare January 11, 2018 00:57

theacodes mentioned this pull request Jan 11, 2018
Revert "Spanner: Make sure **exactly** one of start_*/end_* are p… #4733
Merged

Release Spanner v0.30.0
ded35a1

theacodes force-pushed the release-spanner-v0.30.0 branch from 4efea87 to ded35a1Compare January 11, 2018 17:26

theacodes merged commit 55fd0ff into masterJan 11, 2018

theacodes mentioned this pull request Jan 11, 2018
Spanner v1.0.0 release #4710
Closed
9 tasks

theacodes removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 11, 2018

theacodes deleted the release-spanner-v0.30.0 branch February 14, 2018 04:32

parthea pushed a commit that referenced this pull request Mar 9, 2026
Release Spanner v0.30.0 (#4732)
459d622


		### Implementation Changes

		- The underlying autogenerated client library was re-generated to pick up new features and resolve bugs. (#4695)


		- Brought Spanner README more in line with others. (#4306, #4317)

		### Testing

Uh oh!

Conversation

theacodes commented Jan 10, 2018

Uh oh!

theacodes commented Jan 10, 2018

Uh oh!

dhermes left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented Jan 10, 2018

Uh oh!

dhermes commented Jan 10, 2018

Uh oh!

tseaver commented Jan 10, 2018

Uh oh!

theacodes commented Jan 10, 2018

Uh oh!

theacodes commented Jan 11, 2018

Uh oh!

chemelnucfin commented Jan 11, 2018

Uh oh!

theacodes commented Jan 11, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chemelnucfin commented Jan 11, 2018 via email

Uh oh!

theacodes commented Jan 11, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

theacodes commented Jan 11, 2018•
edited
Loading