Skip to content

Generate gapic for logging, remove all references to gax - #4759

Merged
theacodes merged 5 commits into
masterfrom
regen-logging-gapic
Jan 19, 2018
Merged

Generate gapic for logging, remove all references to gax#4759
theacodes merged 5 commits into
masterfrom
regen-logging-gapic

Conversation

@theacodes

@theacodestheacodes commented Jan 18, 2018

Copy link
Copy Markdown
Contributor

Towards #4692.

This was not fun. Once again, I recommend reviewing commit-by-commit (there's only 2)

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 18, 2018
tseaver
tseaver reviewed Jan 18, 2018
View reviewed changes
Comment threadlogging/docs/conf.py
@@ -0,0 +1,310 @@
# -*- coding: utf-8 -*-

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadlogging/google/cloud/logging_v2/__init__.py
'LoggingServiceV2Client',
'ConfigServiceV2Client',
'MetricsServiceV2Client',
)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadlogging/google/cloud/logging_v2/gapic/metrics_service_v2_client_config.py
}
}
}
}

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadlogging/google/cloud/logging_v2/types.py
for name, message in get_messages(module).items():
message.__module__ = 'google.cloud.logging_v2.types'
setattr(sys.modules[__name__], name, message)
names.append(name)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadlogging/tests/system/test_system.py
@@ -16,14 +16,11 @@
import logging

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadlogging/tests/unit/test_client.py Outdated
self.assertEqual(client.project, self.PROJECT)

def test_logging_api_wo_gax(self):
def test_logging_api_wo_gapi(self):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

lukesneeringer
lukesneeringer reviewed Jan 18, 2018
View reviewed changes
Comment threadlogging/setup.py
'google-api-core >= 0.1.1, < 0.2.0dev',
'gapic-google-cloud-logging-v2 >= 0.91.0, < 0.92dev',
'google-cloud-core >= 0.28.0, < 0.29dev',
'google-api-core[grpc] >= 0.1.1, < 0.2.0dev',

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@theacodes

theacodes commented Jan 18, 2018

Copy link
Copy Markdown
ContributorAuthor

CI is failing due to bigquery non-determinism (addressing in #4760), will rebase and merge when CI is greeeen.

@chemelnucfinchemelnucfin added type: process A process-related concern. May include testing, release, or the like. api: logging Issues related to the Cloud Logging API. labels Jan 19, 2018
@theacodestheacodes mentioned this pull request Jan 19, 2018
Closed
Jon Wayne Parrott added 5 commits January 19, 2018 14:15
Jon Wayne Parrott
Import logging_v2 generated by artman
0f3d38f
Command log:
```
set DEST ~/workspace/google-cloud-python/logging
set GOOGLEAPIS_REV fca7f0706769f8ece08121a87394b7c6e6d87687
cd /tmp
git clone https://github.com/googleapis/googleapis.git
cd googleapis
git reset --hard $GOOGLEAPIS_REV
artman --config google/logging/artman_logging.yaml generate python_gapic
set SRC ./artman-genfiles/python/logging-v2/
set IMPORT_PKG logging_v2
cp -r $SRC/docs $DEST
cp -r $SRC/google/cloud/$IMPORT_PKG $DEST/google/cloud/
mkdir -p $DEST/tests/unit/gapic
cp -r $SRC/tests/unit/gapic $DEST/tests/unit
mkdir -p $DEST/tests/system/gapic
cp -r $SRC/tests/system/gapic $DEST/tests/system
```
Jon Wayne Parrott
Removing all references to gax
c0ddd73
Jon Wayne Parrott
Fix typo
f8f3fbc
Jon Wayne Parrott
Add missing encoding
81eef21
Jon Wayne Parrott
Remove unused test helper
24fd8e5
@theacodes
theacodes merged commit 14ee26f into masterJan 19, 2018
@theacodes
theacodes deleted the regen-logging-gapic branch January 19, 2018 23:15
@theacodestheacodes mentioned this pull request Feb 9, 2018
Closed
8 tasks
parthea pushed a commit that referenced this pull request Nov 24, 2025
Jon Wayne Parrott
Generate gapic for logging, remove all references to gax (#4759)
0caaf78
* Import logging_v2 generated by artman
Command log:
```
set DEST ~/workspace/google-cloud-python/logging
set GOOGLEAPIS_REV fca7f0706769f8ece08121a87394b7c6e6d87687
cd /tmp
git clone https://github.com/googleapis/googleapis.git
cd googleapis
git reset --hard $GOOGLEAPIS_REV
artman --config google/logging/artman_logging.yaml generate python_gapic
set SRC ./artman-genfiles/python/logging-v2/
set IMPORT_PKG logging_v2
cp -r $SRC/docs $DEST
cp -r $SRC/google/cloud/$IMPORT_PKG $DEST/google/cloud/
mkdir -p $DEST/tests/unit/gapic
cp -r $SRC/tests/unit/gapic $DEST/tests/unit
mkdir -p $DEST/tests/system/gapic
cp -r $SRC/tests/system/gapic $DEST/tests/system
```
* Removing all references to gax
* Fix typo
* Add missing encoding
* Remove unused test helper
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@waprinwaprinAwaiting requested review from waprin
2 more reviewers
@tseavertseavertseaver left review comments
@lukesneeringerlukesneeringerlukesneeringer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: loggingIssues related to the Cloud Logging API.cla: yesThis human has signed the Contributor License Agreement.type: processA process-related concern. May include testing, release, or the like.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@theacodes@lukesneeringer@tseaver@chemelnucfin@googlebot