Uh oh!
There was an error while loading. Please reload this page.
Fix variable nanosecond timestamp update_time from response - #4819
Conversation
tswast
left a comment
There was a problem hiding this comment.
LGTM, though we might need a fallback in case microseconds appear again.
We should check with the product team to see what they are committing to.
chemelnucfin
commented
Jan 31, 2018
Would a try except work better then or should we just wait? |
tswast
commented
Feb 1, 2018
I'm emailing the team to check. |
tseaver
commented
Mar 5, 2018
@tswast ping? |
tswast
commented
Mar 5, 2018
I never got a response from the folks I've contacted before on the RuntimeConfig team. @mgannholm Can you comment on this? |
tswast
commented
Mar 6, 2018
Okay, I got confirmation from Victor on the RuntimeConfig team that "it might change from platform to platform". We need to be able to handle both. Yes, try-except would be a good way to do it. Alternatively, I believe we have places (in BigQuery, maybe?) where we try to parse the string a little bit to see how many digits we have before trying to parse. |
7432b55 to
7cd4beeCompare7cd4bee to
2dc2357Compare2dc2357 to
8f38feeComparechemelnucfin
commented
Apr 4, 2018
@tswast PTAL at your convenience. |
| 'name': VARIABLE_PATH, | ||
| 'value': 'bXktdmFyaWFibGUtdmFsdWU=', # base64 my-variable-value | ||
| 'updateTime': '2016-04-14T21:21:54.5000Z', | ||
| 'updateTime': '2016-04-14T21:21:54.123456789Z', |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
chemelnucfin
commented
Apr 4, 2018
going to merge this and diff from this in the new PR. (I have it written already) |
@tswast Thanks for the hint.
Closes#4807