Skip to content

Firestore integer simple fields - #4858

Closed
chemelnucfin wants to merge 1 commit into
googleapis:masterfrom
chemelnucfin:firestore_integer_simple_fields
Closed

Firestore integer simple fields#4858
chemelnucfin wants to merge 1 commit into
googleapis:masterfrom
chemelnucfin:firestore_integer_simple_fields

Conversation

@chemelnucfin

@chemelnucfinchemelnucfin commented Feb 8, 2018

Copy link
Copy Markdown
Contributor

Closes#4320
Diff base is #4851

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 8, 2018
@theacodes

theacodes commented Feb 8, 2018

Copy link
Copy Markdown
Contributor

Is the diffbase necessary?

@chemelnucfin

chemelnucfin commented Feb 8, 2018

Copy link
Copy Markdown
ContributorAuthor

not necessary, but create_if_missing should be removed anyway.

@theacodes

theacodes commented Feb 8, 2018

Copy link
Copy Markdown
Contributor

If it can be done without it, please do. You can graft your commit onto master by using git rebase -i master and dropping the unrelated commits.

@chemelnucfin
chemelnucfinforce-pushed the firestore_integer_simple_fields branch from e0a5f19 to 2e72c7eCompareFebruary 8, 2018 18:33
@chemelnucfin

chemelnucfin commented Feb 8, 2018

Copy link
Copy Markdown
ContributorAuthor

that was bad, wait a minute

@chemelnucfin
chemelnucfinforce-pushed the firestore_integer_simple_fields branch from 2e72c7e to 640a9e7CompareFebruary 8, 2018 18:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringerlukesneeringerAwaiting requested review from lukesneeringer

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chemelnucfin@theacodes@googlebot