Skip to content

WIP Firestore: replace gax and regenerate gapic - #4880

Closed
chemelnucfin wants to merge 2 commits into
googleapis:masterfrom
chemelnucfin:firestore_regenerate_gapic
Closed

WIP Firestore: replace gax and regenerate gapic#4880
chemelnucfin wants to merge 2 commits into
googleapis:masterfrom
chemelnucfin:firestore_regenerate_gapic

Conversation

@chemelnucfin

@chemelnucfinchemelnucfin commented Feb 14, 2018

Copy link
Copy Markdown
Contributor

Toward #4692

@jonparrott I haven't ran the tests yet, but something like this?

It looks like it's removed some enums that wasn't replaced. Is that correct behavior?

@chemelnucfinchemelnucfin added api: firestore Issues related to the Firestore API. type: cleanup An internal cleanup or hygiene concern. labels Feb 14, 2018
@chemelnucfinchemelnucfin self-assigned this Feb 14, 2018
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 14, 2018
@chemelnucfin
chemelnucfinforce-pushed the firestore_regenerate_gapic branch from 92752ad to 35445ebCompareFebruary 14, 2018 16:58
@chemelnucfin
chemelnucfinforce-pushed the firestore_regenerate_gapic branch from 35445eb to 062d2a2CompareFebruary 14, 2018 17:02
@chemelnucfin
chemelnucfinforce-pushed the firestore_regenerate_gapic branch from 819209c to 7aa9589CompareFebruary 15, 2018 02:33
@chemelnucfin

Copy link
Copy Markdown
ContributorAuthor

@jonparrott I have fixed the unit tests, but I haven't figured out what's causing the 504 deadline_exceeded errors in the system tests. There're also some gax stuff in gapic/firestore_admin_client.py that I had to edit manually, which didn't seem right.

I'll probably head back to pubsub again and then come back to this. If you see something obvious that I'm doing wrong, please let me know. thanks.

@chemelnucfin

Copy link
Copy Markdown
ContributorAuthor

I also looked at the config files, but think that the commits should not be idempotent. I did also try to retry the nonidempotent ones with deadline_exceeded though.

@theacodes

Copy link
Copy Markdown
Contributor

@chemelnucfin no worries. Thanks for giving this a shot but pubsub is absolutely a higher priority.

@chemelnucfin

Copy link
Copy Markdown
ContributorAuthor

Closing for now

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestoreIssues related to the Firestore API.cla: yesThis human has signed the Contributor License Agreement.type: cleanupAn internal cleanup or hygiene concern.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@chemelnucfin@theacodes@googlebot