BigTable: provide better access to cell values by zakons · Pull Request #4908 · googleapis/google-cloud-python

zakons · 2018-02-21T05:01:57Z

Add methods to provide better access to cell values, with performance and ease of use being additional goals.

googlebot · 2018-02-21T05:02:01Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

zakons · 2018-02-21T05:06:15Z

Please accept my consent for all commits, passing the CLA check.

theacodes · 2018-02-21T17:13:29Z

CLAbot has some issues with mixed authorship. Both you and @aneepct have signed the CLA, so don't worry about it.

theacodes · 2018-02-21T17:15:09Z

@tseaver can you also take a look at this?

Sign in to view

+ except KeyError:
+ raise KeyError(_MISSING_COLUMN.format(column, column_family_id))
+
+ return cells


Sign in to view

+
+ return cell.value
+
+ def cell_values(self, column_family_id, column, max_count=-1):


Sign in to view

+ if max_count == -1:
+ max_count = len(cells)
+
+ for index, cell in enumerate(cells):


theacodes · 2018-02-21T21:20:17Z

Does this supersede #4564? If so, can you close it?

zakons · 2018-03-15T04:09:17Z

Thanks!

zakonsand others added 9 commits February 20, 2018 00:58

Create a generator for cell values
0fd6358

Create unit tests for row_data
6d3c914

Change yield on cell_values.
f88e6b4

Remove unused imports
832ff0d

Update unit test
a7c66ad

Make find_cells public.
9def9d7

Revert yield cell changes
4a73447

Refactor test classes.
5d94284

Refactor test classes.
c58c047

zakons requested a review from lukesneeringer as a code owner February 21, 2018 05:01

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Feb 21, 2018

theacodes approved these changes Feb 21, 2018
View reviewed changes

theacodes requested a review from tseaver February 21, 2018 17:15

tseaver suggested changes Feb 21, 2018
View reviewed changes

Change default for max_count to None.
f30e84e

zakons mentioned this pull request Feb 23, 2018
Add get_cell() and get_cells() methods to PartialRowData #4564
Closed

tseaver approved these changes Mar 14, 2018
View reviewed changes

tseaver merged commit 7cf610b into googleapis:masterMar 14, 2018

zakons deleted the feature/cell_values branch March 20, 2018 03:38

parthea pushed a commit that referenced this pull request Nov 22, 2025
BigTable: provide better access to cell values (#4908)
544bb9c


		return cell.value

		def cell_values(self, column_family_id, column, max_count=-1):

Uh oh!

Conversation

zakons commented Feb 21, 2018

Uh oh!

googlebot commented Feb 21, 2018

Uh oh!

zakons commented Feb 21, 2018

Uh oh!

theacodes commented Feb 21, 2018

Uh oh!

theacodes commented Feb 21, 2018

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

theacodes commented Feb 21, 2018

Uh oh!

zakons commented Mar 15, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants